Wrong stage icon in Stages of Pipelines (10.8 thru 14.8 and now)
<!--IssueSummary start--> <details> <summary> Everyone can contribute. [Help move this issue forward](https://handbook.gitlab.com/handbook/marketing/developer-relations/contributor-success/community-contributors-workflows/#contributor-links) while earning points, leveling up and collecting rewards. </summary> - [Close this issue](https://contributors.gitlab.com/manage-issue?action=close&projectId=278964&issueIid=22537) </details> <!--IssueSummary end--> ### Summary When all Jobs with a manual trigger in a Stage are canceled, a wrong icon is shown for the Stage in the Stages column in project's Pipelines page. ### Steps to reproduce https://gitlab.com/zarunet/test-project/-/pipelines ### Example Project https://gitlab.com/zarunet/test-project/-/pipelines ### What is the current *bug* behavior? ![pipelines-stages-icon-for-canceled](/uploads/6deff55e5675ccf31998ca0c49b60712/pipelines-stages-icon-for-canceled.png) ### What is the expected *correct* behavior? The (summary) icon for a stage with allowed-failure job(s) should be "canceled" instead of "passed with warnings" even when the pipeline is canceled. ### Relevant logs and/or screenshots ![pipelines-stages-icon-for-canceled](/uploads/6deff55e5675ccf31998ca0c49b60712/pipelines-stages-icon-for-canceled.png) ### Output of checks This bug happens on GitLab.com at least 10.8 (2018-06) through 14.7 and 14.8-pre (2022-02). ### Possible fixes "Canceled" should precede "passed with warnings" when the status is computed.
issue