<!-- The first four sections: "Problem to solve", "Intended users", "User experience goal", and "Proposal", are strongly recommended, while the rest of the sections can be filled out during the problem validation or breakdown phase. However, keep in mind that providing complete and relevant information early helps our product team validate the problem and start working on a solution. --> ### Problem to solve Sometimes I'm not fully satisfied with the code and I don't want to approve specific merge request. At the same time team is under heavy pressure to deliver feature/bugfix. Approving bad code means that person takes responsibility that this piece of code was reviewed without any major concerns which puts me under two fires. ### Intended users Merge request approvers. ### User experience goal <!-- What is the single user experience workflow this problem addresses? For example, "The user should be able to use the UI/API/.gitlab-ci.yml with GitLab to <perform a specific task>" https://about.gitlab.com/handbook/engineering/ux/ux-research-training/user-story-mapping/ --> ### Proposal Introduce "Acceptable" and "It works" statuses and add ability to specify their weight (e.g. 0.75 and 0.5 correspondingly). * Acceptable - feature works but some part of the code could be done better and this can/should be changed in future. * It works - urgent feature that must be delivered yesterday that has quick fixes, hacks and terrible code that must be changed as soon as possible but proper fix takes too much time. Some minor functionality may be broken. This approach keeps track on quality of the code and allow to have dynamic number of required approvals. ### Further details For instance minimum required approvals is 2. This means that following combinations are possible: 1. Acceptable, Acceptable, It works => 0.75 + 0.75 + 0.5 = 2 2. Approved, It works, It works => 1 + 0.5 + 0.5 = 2 3. Acceptable, Acceptable, Approved => 0.75 + 0.75 + 1 = 2.5 and so on. ### Permissions and Security Code reviewer ### Documentation <!-- See the Feature Change Documentation Workflow https://docs.gitlab.com/ee/development/documentation/workflow.html#for-a-product-change * Add all known Documentation Requirements in this section. See https://docs.gitlab.com/ee/development/documentation/feature-change-workflow.html#documentation-requirements * If this feature requires changing permissions, update the permissions document. See https://docs.gitlab.com/ee/user/permissions.html --> ### Availability & Testing <!-- This section needs to be retained and filled in during the workflow planning breakdown phase of this feature proposal, if not earlier. What risks does this change pose to our availability? How might it affect the quality of the product? What additional test coverage or changes to tests will be needed? Will it require cross-browser testing? Please list the test areas (unit, integration and end-to-end) that needs to be added or updated to ensure that this feature will work as intended. Please use the list below as guidance. * Unit test changes * Integration test changes * End-to-end test change See the test engineering planning process and reach out to your counterpart Software Engineer in Test for assistance: https://about.gitlab.com/handbook/engineering/quality/test-engineering/#test-planning --> ### What does success look like, and how can we measure that? <!-- Define both the success metrics and acceptance criteria. Note that success metrics indicate the desired business outcomes, while acceptance criteria indicate when the solution is working correctly. If there is no way to measure success, link to an issue that will implement a way to measure this. --> ### What is the type of buyer? <!-- What is the buyer persona for this feature? See https://about.gitlab.com/handbook/marketing/product-marketing/roles-personas/buyer-persona/ In which enterprise tier should this feature go? See https://about.gitlab.com/handbook/product/pricing/#four-tiers --> ### Is this a cross-stage feature? <!-- Communicate if this change will affect multiple Stage Groups or product areas. We recommend always start with the assumption that a feature request will have an impact into another Group. Loop in the most relevant PM and Product Designer from that Group to provide strategic support to help align the Group's broader plan and vision, as well as to avoid UX and technical debt. https://about.gitlab.com/handbook/product/#cross-stage-features --> ### Links / references