### Problem to solve Teams want to contribute to Code Quality features but with the majority of the feature set being in the ~"GitLab Starter" tier they are not incentivized to do so. As such there have been no community contributions. ### Intended users * [Sasha (Software Developer)](https://about.gitlab.com/handbook/marketing/product-marketing/roles-personas/#sasha-software-developer) ### Further details <!-- Include use cases, benefits, and/or goals (contributes to our vision?) --> As noted in the [blog post](https://about.gitlab.com/blog/2020/03/30/new-features-to-core/) features are priced to the user most likely to be a champion for the feature. As we think about the features in the [Code Quality](https://docs.gitlab.com/ee/user/project/merge_requests/code_quality.html) feature it is clear that the MR widget that details improvements and degradations in code quality associated with the merge are likely to be used and championed by the individual user. As such this feature belongs in the ~"Category:DevOps Score" tier. ### Proposal Move the MR Widget functionality from the ~"GitLab Starter" to the ~"GitLab Core" tier. Leave the Full Code Quality report in the ~"GitLab Starter" tier. Only the ~frontend code needs to be moved for this. 1. Create a `app/assets/javascripts/reports/code_quality` folder to contain the core code quality. 1. Create a `code_quality_report.vue` file in the above directory. In this file we will render the `<report-section>` that [is found in the `mr_widget_options` file](https://gitlab.com/gitlab-org/gitlab/-/blob/a8217a61446851dee495061d3ad8237e656eea61/ee/app/assets/javascripts/vue_merge_request_widget/mr_widget_options.vue#L276). 1. Create a store to fetch the code quality reports for the base path and head path, which we will pass into the component from the core `mr_widget_options` component. 1. Add the comparison to the store [which currently exists in the `mr_widget_store`](https://gitlab.com/gitlab-org/gitlab/-/blob/a8217a61446851dee495061d3ad8237e656eea61/ee/app/assets/javascripts/vue_merge_request_widget/stores/mr_widget_store.js#L110). 1. Create the specs for the new `code_quality_report.vue` and store. 1. Remove the specs [from the `mr_widget_store_spec`](https://gitlab.com/gitlab-org/gitlab/-/blob/a8217a61446851dee495061d3ad8237e656eea61/ee/spec/frontend/vue_mr_widget/stores/mr_widget_store_spec.js#L18). <!-- How are we going to solve the problem? Try to include the user journey! https://about.gitlab.com/handbook/journeys/#user-journey --> ### Permissions and Security <!-- What permissions are required to perform the described actions? Are they consistent with the existing permissions as documented for users, groups, and projects as appropriate? Is the proposed behavior consistent between the UI, API, and other access methods (e.g. email replies)?--> ### Documentation <!-- See the Feature Change Documentation Workflow https://docs.gitlab.com/ee/development/documentation/feature-change-workflow.html Add all known Documentation Requirements here, per https://docs.gitlab.com/ee/development/documentation/feature-change-workflow.html#documentation-requirements If this feature requires changing permissions, this document https://docs.gitlab.com/ee/user/permissions.html must be updated accordingly. --> Update the [Code Quality Documentation](https://docs.gitlab.com/ee/user/project/merge_requests/code_quality.html) to better explain what parts of this feature are in each tier. ### Availability & Testing <!-- This section needs to be retained and filled in during the workflow planning breakdown phase of this feature proposal, if not earlier. What risks does this change pose to our availability? How might it affect the quality of the product? What additional test coverage or changes to tests will be needed? Will it require cross-browser testing? Please list the test areas (unit, integration and end-to-end) that needs to be added or updated to ensure that this feature will work as intended. Please use the list below as guidance. * Unit test changes * Integration test changes * End-to-end test change See the test engineering planning process and reach out to your counterpart Software Engineer in Test for assistance: https://about.gitlab.com/handbook/engineering/quality/test-engineering/#test-planning --> Risk for activity like this is typically centered around authorization, however since this feature is being moved to core and thus available to every user, risk in this area is minimal. * movement and execution of the existing unit tests should be sufficient * `package-and-qa` is not required ### What does success look like, and how can we measure that? <!-- Define both the success metrics and acceptance criteria. Note that success metrics indicate the desired business outcomes, while acceptance criteria indicate when the solution is working correctly. If there is no way to measure success, link to an issue that will implement a way to measure this. --> Users of GitLab free can see the Code Quality MR Widget after this change is live. ### What is the type of buyer? <!-- Which leads to: in which enterprise tier should this feature go? See https://about.gitlab.com/handbook/product/pricing/#four-tiers --> See the Proposal above, this is moving to ~"GitLab Core" ### Is this a cross-stage feature? <!-- Communicate if this change will affect multiple Stage Groups or product areas. We recommend always start with the assumption that a feature request will have an impact into another Group. Loop in the most relevant PM and Product Designer from that Group to provide strategic support to help align the Group's broader plan and vision, as well as to avoid UX and technical debt. https://about.gitlab.com/handbook/product/#cross-stage-features --> No. ### Links / references