<!--IssueSummary start--> <details> <summary> Everyone can contribute. [Help move this issue forward](https://handbook.gitlab.com/handbook/marketing/developer-relations/contributor-success/community-contributors-workflows/#contributor-links) while earning points, leveling up and collecting rewards. </summary> - [Close this issue](https://contributors.gitlab.com/manage-issue?action=close&projectId=278964&issueIid=18399) </details> <!--IssueSummary end--> The following discussion from gitlab-ce!11845 should be addressed: - [ ] @godfat commented on a [discussion](https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11845#note_31513550): (+2 comments) > I agree. Reading through related codes, I could see there are ancient codes which really needs some cleanup, and we certainly can't do all of them here... so we need to find a fine line here, for what we should really clear up right now, and what we could leave to the next iteration (or rather, a cleanup/refactoring MR) > > Feel free to resolve this or make an issue for it. The quoted discussion was regarding the JWT controller, and its testing. Both need a cleanup which we should perform soon.