"Temp fix" rescue in note.rb
[Commit from January 20, 2012](https://gitlab.com/gitlab-org/gitlab-ce/commit/3d7b35a37d30365088947de0cf85cc7d4af79162#82f5d4f89a95414eac71b95d163c05ba59183d6d_55_56): ``` # Temp fix to prevent app crash # if note commit id doesnt exist ``` And [the file as it is today](https://gitlab.com/gitlab-org/gitlab-ce/blob/1fbea7cec974d3c215c0e5fae389c05b802b0600/app/models/note.rb#L324): ``` # Temp fix to prevent app crash # if note commit id doesn't exist ``` Four years of a "temp" fix :stuck_out_tongue_closed_eyes: `rescue` is [really](http://technicaldebt.com/the-cost-of-using-rubys-rescue-as-logic/) [really](https://simonecarletti.com/blog/2010/01/how-slow-are-ruby-exceptions/) slow. So we should probably get rid of that. cc: @dzaporozhets @rspeicher @yorickpeterse
issue