-
🔴 @jannik_lehmannMaintainerSuggestions to add:
-
Does this implementation involve new assets or dependencies? If so: -
Do I have everything I need to embed those in the most performant way possible?
-
-
Does this feature add significant weight to the sites performance? If so: -
Could this weight be avoided/reduced??
-
-
-
🔴 @markrianMaintainerAnother suggestion:
-
Design System. Are all UI elements representable with existing GitLab UI components?
Edited by Mark Florian -
-
Thank you for the great suggestions @jannik_lehmann and @markrian! I've added them to the checklist.
-
@nmccorrison do you have a link to that discussion? It would probably be worth adding an item, yes. I'm curious to see what kind of formatting we're thinking of though.
-
😺 @cam.xDeveloperI think what @nmccorrison mentioned is like date format, time format, number format etc.
We can add something like:
-
Is copy reviewed? -
Is all data format, such as date, number aligned with the generic format used in gitlab
-
-
Thanks @cam.x! I've updated the
Labels
section accordingly. -
Yes, thanks @cam.x. Here is a follow-up issue tracking some updates on a new page. #328475 (closed)
Please register or sign in to comment