Merge branch 'rails-save-bang-34' into 'master'

Fix Rails/SaveBang offenses

See merge request !42780
136 jobs for !42780 with rails-save-bang-34 into master in 45 minutes and 30 seconds (queued for 6 seconds)
Status Job ID Name Coverage
  Sync
manual #748252466
gitlab-org allowed to fail manual
dont-interrupt-me
 
  Prepare
passed #748252469
gitlab-org
compile-production-assets

00:29:40

passed #748252470
gitlab-org
compile-test-assets

00:08:16

passed #748252472
gitlab-org
compile-test-assets as-if-foss

00:07:31

passed #748252477
gitlab-org
detect-tests

00:01:29

passed #748252479
gitlab-org
detect-tests as-if-foss

00:01:32

passed #748252482
gitlab-org
retrieve-tests-metadata

00:01:37

manual #748252475
gitlab-org allowed to fail manual
review-cleanup
passed #748252476
gitlab-org
review-stop-failed-deployment

00:02:53

passed #748252474
gitlab-org
setup-test-env

00:09:01

 
  Build Images
passed #748252487
gitlab-org
build-assets-image

00:03:15

passed #748252485
gitlab-org
build-qa-image

00:02:31

 
  Fixtures
passed #748252488
gitlab-org
frontend-fixtures

00:14:52

 
  Test
passed #748252503
gitlab-org
brakeman-sast

00:05:26

passed #748252502
gitlab-org-docker
code_quality

00:17:42

passed #748252680
gitlab-org
danger-review

00:03:42

passed #748252615
gitlab-org
db:check-schema

00:04:15

passed #748252507
gitlab-org-docker
dependency_scanning

00:12:11

passed #748252512
gitlab-org
downtime_check

00:03:56

passed #748252504
gitlab-org
eslint-sast

00:02:42

passed #748252682
gitlab-org
gitlab_git_test

00:01:27

passed #748252490
gitlab-org
graphql-reference-verify

00:04:59

passed #748252492
gitlab-org
jest 1/4

00:12:49

passed #748252493
gitlab-org
jest 2/4

00:12:43

passed #748252494
gitlab-org
jest 3/4

00:13:35

passed #748252495
gitlab-org
jest 4/4

00:14:22

passed #748252496
gitlab-org
jest-integration

00:03:28

passed #748252491
gitlab-org
karma

00:03:03

38.88%
passed #748252689
gitlab-org
lint-ci-gitlab

00:01:57

passed #748252499
gitlab-org
memory-on-boot

00:05:41

passed #748252498
gitlab-org
memory-static

00:04:43

passed #748252505
gitlab-org
nodejs-scan-sast

00:01:47

passed #748252500
gitlab-org
qa:internal

00:01:44

passed #748252501
gitlab-org
qa:selectors

00:01:47

passed #748252676
gitlab-org
rspec fail-fast

00:08:23

passed #748252678
gitlab-org
rspec foss-impact

00:06:40

passed #748252541
gitlab-org
rspec integration pg11 1/8

00:15:25

passed #748252543
gitlab-org
rspec integration pg11 2/8

00:20:00

passed #748252545
gitlab-org
rspec integration pg11 3/8

00:23:42

passed #748252546
gitlab-org
rspec integration pg11 4/8

00:21:41

passed #748252547
gitlab-org
rspec integration pg11 5/8

00:23:15

passed #748252548
gitlab-org
rspec integration pg11 6/8

00:23:56

passed #748252550
gitlab-org
rspec integration pg11 7/8

00:20:38

passed #748252551
gitlab-org
rspec integration pg11 8/8

00:21:19

passed #748252552
gitlab-org
rspec system pg11 1/24

00:19:15

passed #748252567
gitlab-org
rspec system pg11 10/24

00:19:03

passed #748252571
gitlab-org
rspec system pg11 11/24

00:22:33

passed #748252574
gitlab-org
rspec system pg11 12/24

00:19:19

passed #748252578
gitlab-org
rspec system pg11 13/24

00:21:08

passed #748252580
gitlab-org
rspec system pg11 14/24

00:19:51

passed #748252584
gitlab-org
rspec system pg11 15/24

00:23:01

passed #748252587
gitlab-org
rspec system pg11 16/24

00:18:22

passed #748252590
gitlab-org
rspec system pg11 17/24

00:20:59

passed #748252592
gitlab-org
rspec system pg11 18/24

00:17:52

passed #748252596
gitlab-org
rspec system pg11 19/24

00:19:05

passed #748252553
gitlab-org
rspec system pg11 2/24

00:18:12

passed #748252599
gitlab-org
rspec system pg11 20/24

00:18:19

passed #748252602
gitlab-org
rspec system pg11 21/24

00:18:31

passed #748252606
gitlab-org
rspec system pg11 22/24

00:19:30

passed #748252609
gitlab-org
rspec system pg11 23/24

00:19:42

passed #748252612
gitlab-org
rspec system pg11 24/24

00:21:03

passed #748252554
gitlab-org
rspec system pg11 3/24

00:19:28

passed #748252555
gitlab-org
rspec system pg11 4/24

00:18:22

passed #748252558
gitlab-org
rspec system pg11 5/24

00:19:47

passed #748252560
gitlab-org
rspec system pg11 6/24

00:17:14

passed #748252561
gitlab-org
rspec system pg11 7/24

00:19:26

passed #748252562
gitlab-org
rspec system pg11 8/24

00:16:42

passed #748252564
gitlab-org
rspec system pg11 9/24

00:17:23

passed #748252513
gitlab-org
rspec unit pg11 1/20

00:18:38

passed #748252527
gitlab-org
rspec unit pg11 10/20

00:22:58

passed #748252528
gitlab-org
rspec unit pg11 11/20

00:18:49

passed #748252529
gitlab-org
rspec unit pg11 12/20

00:21:30

passed #748252530
gitlab-org
rspec unit pg11 13/20

00:17:48

passed #748252531
gitlab-org
rspec unit pg11 14/20

00:22:01

passed #748252532
gitlab-org
rspec unit pg11 15/20

00:19:52

passed #748252534
gitlab-org
rspec unit pg11 16/20

00:21:24

passed #748252535
gitlab-org
rspec unit pg11 17/20

00:23:35

passed #748252536
gitlab-org
rspec unit pg11 18/20

00:22:48

passed #748252538
gitlab-org
rspec unit pg11 19/20

00:20:24

passed #748252514
gitlab-org
rspec unit pg11 2/20

00:20:23

passed #748252540
gitlab-org
rspec unit pg11 20/20

00:19:41

passed #748252517
gitlab-org
rspec unit pg11 3/20

00:18:53

passed #748252520
gitlab-org
rspec unit pg11 4/20

00:20:50

passed #748252521
gitlab-org
rspec unit pg11 5/20

00:21:39

passed #748252522
gitlab-org
rspec unit pg11 6/20

00:19:17

passed #748252523
gitlab-org
rspec unit pg11 7/20

00:17:23

passed #748252524
gitlab-org
rspec unit pg11 8/20

00:20:42

passed #748252526
gitlab-org
rspec unit pg11 9/20

00:19:11

passed #748252641
gitlab-org
rspec-ee integration pg11 1/4

00:16:26

passed #748252643
gitlab-org
rspec-ee integration pg11 2/4

00:18:10

passed #748252645
gitlab-org
rspec-ee integration pg11 3/4

00:19:59

passed #748252646
gitlab-org
rspec-ee integration pg11 4/4

00:17:23

passed #748252669
gitlab-org
rspec-ee integration pg11 geo

00:10:11

passed #748252648
gitlab-org
rspec-ee system pg11 1/6

00:18:01

passed #748252650
gitlab-org
rspec-ee system pg11 2/6

00:23:29

passed #748252652
gitlab-org
rspec-ee system pg11 3/6

00:19:31

passed #748252654
gitlab-org
rspec-ee system pg11 4/6

00:19:47

passed #748252656
gitlab-org
rspec-ee system pg11 5/6

00:19:26

passed #748252658
gitlab-org
rspec-ee system pg11 6/6

00:19:01

passed #748252672
gitlab-org
rspec-ee system pg11 geo

00:11:52

passed #748252618
gitlab-org
rspec-ee unit pg11 1/10

00:20:04

passed #748252639
gitlab-org
rspec-ee unit pg11 10/10

00:18:59

passed #748252621
gitlab-org
rspec-ee unit pg11 2/10

00:16:51

passed #748252623
gitlab-org
rspec-ee unit pg11 3/10

00:16:46

passed #748252626
gitlab-org
rspec-ee unit pg11 4/10

00:17:56

passed #748252628
gitlab-org
rspec-ee unit pg11 5/10

00:20:41

passed #748252630
gitlab-org
rspec-ee unit pg11 6/10

00:18:23

passed #748252632
gitlab-org
rspec-ee unit pg11 7/10

00:22:44

passed #748252635
gitlab-org
rspec-ee unit pg11 8/10

00:22:46

passed #748252637
gitlab-org
rspec-ee unit pg11 9/10

00:19:55

passed #748252660
gitlab-org
rspec-ee unit pg11 geo 1/2

00:13:24

passed #748252665
gitlab-org
rspec-ee unit pg11 geo 2/2

00:17:29

passed #748252686
gitlab-org
run-dev-fixtures

00:06:05

passed #748252688
gitlab-org
run-dev-fixtures-ee

00:08:23

passed #748252506
gitlab-org
secrets-sast

00:04:20

passed #748252508
gitlab-org
static-analysis 1/4

00:16:49

passed #748252509
gitlab-org
static-analysis 2/4

00:09:39

passed #748252510
gitlab-org
static-analysis 3/4

00:36:05

passed #748252511
gitlab-org
static-analysis 4/4

00:08:24

passed #748252684
gitlab-org
verify-tests-yml

00:02:00

passed #748252497
gitlab-org
webpack-dev-server

00:05:08

 
  Post Test
passed #748252690
gitlab-org
coverage-frontend

00:03:11

73.81%
skipped #748252692
gitlab-org
fail-pipeline-early
passed #748252691
gitlab-org
rspec:coverage

00:07:09

94.34%
 
  Review Prepare
manual #748252693
gitlab-org allowed to fail manual
review-build-cng
 
  Review
manual #748252694
gitlab-org allowed to fail manual
review-deploy
 
  Qa
manual #748252695
prm allowed to fail manual
package-and-qa
manual #748252705
gitlab-org allowed to fail manual
review-performance
manual #748252697
gitlab-org-docker allowed to fail manual
review-qa-all 1/5
manual #748252699
gitlab-org-docker allowed to fail manual
review-qa-all 2/5
manual #748252701
gitlab-org-docker allowed to fail manual
review-qa-all 3/5
manual #748252702
gitlab-org-docker allowed to fail manual
review-qa-all 4/5
manual #748252703
gitlab-org-docker allowed to fail manual
review-qa-all 5/5
manual #748252696
gitlab-org-docker allowed to fail manual
review-qa-smoke
 
  Post Qa
manual #748252710
gitlab-org allowed to fail manual
parallel-spec-reports
manual #748252707
gitlab-org allowed to fail manual
review-stop