Merge branch 'rails-save-bang-33' into 'master'

Fix Rails/SaveBang offenses for spec/services/milestones/*

See merge request !42775
136 jobs for !42775 with rails-save-bang-33 into master in 48 minutes and 10 seconds (queued for 4 seconds)
Status Job ID Name Coverage
  Sync
manual #746753643
gitlab-org allowed to fail manual
dont-interrupt-me
 
  Prepare
passed #746753644
gitlab-org
compile-production-assets

00:07:06

passed #746753646
gitlab-org
compile-test-assets

00:07:49

passed #746753649
gitlab-org
compile-test-assets as-if-foss

00:08:03

passed #746753653
gitlab-org
detect-tests

00:01:41

passed #746753654
gitlab-org
detect-tests as-if-foss

00:01:32

passed #746753655
gitlab-org
retrieve-tests-metadata

00:01:33

manual #746753651
gitlab-org allowed to fail manual
review-cleanup
passed #746753652
gitlab-org
review-stop-failed-deployment

00:02:45

passed #746753650
gitlab-org
setup-test-env

00:08:41

 
  Build Images
passed #746753657
gitlab-org
build-assets-image

00:02:42

passed #746753656
gitlab-org
build-qa-image

00:02:28

 
  Fixtures
passed #746753658
gitlab-org
frontend-fixtures

00:16:41

 
  Test
passed #746753672
gitlab-org
brakeman-sast

00:04:20

passed #746753671
gitlab-org-docker
code_quality

00:18:53

passed #746753762
gitlab-org
danger-review

00:03:26

passed #746753734
gitlab-org
db:check-schema

00:04:37

passed #746753676
gitlab-org-docker
dependency_scanning

00:12:09

passed #746753681
gitlab-org
downtime_check

00:04:06

passed #746753673
gitlab-org
eslint-sast

00:02:36

passed #746753763
gitlab-org
gitlab_git_test

00:01:35

passed #746753659
gitlab-org
graphql-reference-verify

00:05:47

passed #746753661
gitlab-org
jest 1/4

00:14:47

passed #746753662
gitlab-org
jest 2/4

00:12:47

passed #746753663
gitlab-org
jest 3/4

00:14:15

passed #746753664
gitlab-org
jest 4/4

00:15:56

passed #746753665
gitlab-org
jest-integration

00:03:14

passed #746753660
gitlab-org
karma

00:02:54

38.88%
passed #746753769
gitlab-org
lint-ci-gitlab

00:01:29

passed #746753668
gitlab-org
memory-on-boot

00:06:35

passed #746753667
gitlab-org
memory-static

00:07:24

passed #746753674
gitlab-org
nodejs-scan-sast

00:01:40

passed #746753669
gitlab-org
qa:internal

00:01:38

passed #746753670
gitlab-org
qa:selectors

00:03:43

passed #746753760
gitlab-org
rspec fail-fast

00:07:50

passed #746753761
gitlab-org
rspec foss-impact

00:07:14

passed #746753702
gitlab-org
rspec integration pg11 1/8

00:22:08

passed #746753703
gitlab-org
rspec integration pg11 2/8

00:21:32

passed #746753704
gitlab-org
rspec integration pg11 3/8

00:21:28

passed #746753705
gitlab-org
rspec integration pg11 4/8

00:18:23

passed #746753706
gitlab-org
rspec integration pg11 5/8

00:21:20

passed #746753707
gitlab-org
rspec integration pg11 6/8

00:23:38

passed #746753708
gitlab-org
rspec integration pg11 7/8

00:19:48

passed #746753709
gitlab-org
rspec integration pg11 8/8

00:19:08

passed #746753710
gitlab-org
rspec system pg11 1/24

00:18:43

passed #746753719
gitlab-org
rspec system pg11 10/24

00:20:13

passed #746753720
gitlab-org
rspec system pg11 11/24

00:19:36

passed #746753721
gitlab-org
rspec system pg11 12/24

00:19:11

passed #746753722
gitlab-org
rspec system pg11 13/24

00:18:30

passed #746753723
gitlab-org
rspec system pg11 14/24

00:18:22

passed #746753724
gitlab-org
rspec system pg11 15/24

00:15:59

passed #746753725
gitlab-org
rspec system pg11 16/24

00:17:32

passed #746753726
gitlab-org
rspec system pg11 17/24

00:18:43

passed #746753727
gitlab-org
rspec system pg11 18/24

00:17:11

passed #746753728
gitlab-org
rspec system pg11 19/24

00:21:03

passed #746753711
gitlab-org
rspec system pg11 2/24

00:18:11

passed #746753729
gitlab-org
rspec system pg11 20/24

00:18:23

passed #746753730
gitlab-org
rspec system pg11 21/24

00:19:12

passed #746753731
gitlab-org
rspec system pg11 22/24

00:17:31

passed #746753732
gitlab-org
rspec system pg11 23/24

00:22:57

passed #746753733
gitlab-org
rspec system pg11 24/24

00:17:32

passed #746753712
gitlab-org
rspec system pg11 3/24

00:20:36

passed #746753713
gitlab-org
rspec system pg11 4/24

00:19:21

passed #746753714
gitlab-org
rspec system pg11 5/24

00:17:03

passed #746753715
gitlab-org
rspec system pg11 6/24

00:20:01

passed #746753716
gitlab-org
rspec system pg11 7/24

00:18:03

passed #746753717
gitlab-org
rspec system pg11 8/24

00:18:07

passed #746753718
gitlab-org
rspec system pg11 9/24

00:20:11

passed #746753682
gitlab-org
rspec unit pg11 1/20

00:18:30

passed #746753691
gitlab-org
rspec unit pg11 10/20

00:20:47

passed #746753692
gitlab-org
rspec unit pg11 11/20

00:22:43

passed #746753693
gitlab-org
rspec unit pg11 12/20

00:20:10

passed #746753694
gitlab-org
rspec unit pg11 13/20

00:23:30

passed #746753695
gitlab-org
rspec unit pg11 14/20

00:21:50

passed #746753696
gitlab-org
rspec unit pg11 15/20

00:19:16

passed #746753697
gitlab-org
rspec unit pg11 16/20

00:20:45

passed #746753698
gitlab-org
rspec unit pg11 17/20

00:22:48

passed #746753699
gitlab-org
rspec unit pg11 18/20

00:26:49

passed #746753700
gitlab-org
rspec unit pg11 19/20

00:19:56

passed #746753683
gitlab-org
rspec unit pg11 2/20

00:20:00

passed #746753701
gitlab-org
rspec unit pg11 20/20

00:20:19

passed #746753684
gitlab-org
rspec unit pg11 3/20

00:17:55

passed #746753685
gitlab-org
rspec unit pg11 4/20

00:21:09

passed #746753686
gitlab-org
rspec unit pg11 5/20

00:17:46

passed #746753687
gitlab-org
rspec unit pg11 6/20

00:19:23

passed #746753688
gitlab-org
rspec unit pg11 7/20

00:20:06

passed #746753689
gitlab-org
rspec unit pg11 8/20

00:19:09

passed #746753690
gitlab-org
rspec unit pg11 9/20

00:20:22

passed #746753745
gitlab-org
rspec-ee integration pg11 1/4

00:16:56

passed #746753746
gitlab-org
rspec-ee integration pg11 2/4

00:18:04

passed #746753747
gitlab-org
rspec-ee integration pg11 3/4

00:16:27

passed #746753748
gitlab-org
rspec-ee integration pg11 4/4

00:16:55

passed #746753758
gitlab-org
rspec-ee integration pg11 geo

00:10:20

passed #746753749
gitlab-org
rspec-ee system pg11 1/6

00:19:26

passed #746753750
gitlab-org
rspec-ee system pg11 2/6

00:22:29

passed #746753752
gitlab-org
rspec-ee system pg11 3/6

00:19:32

passed #746753753
gitlab-org
rspec-ee system pg11 4/6

00:20:13

passed #746753754
gitlab-org
rspec-ee system pg11 5/6

00:21:12

passed #746753755
gitlab-org
rspec-ee system pg11 6/6

00:19:11

passed #746753759
gitlab-org
rspec-ee system pg11 geo

00:11:08

passed #746753735
gitlab-org
rspec-ee unit pg11 1/10

00:19:19

passed #746753744
gitlab-org
rspec-ee unit pg11 10/10

00:21:01

passed #746753736
gitlab-org
rspec-ee unit pg11 2/10

00:18:33

passed #746753737
gitlab-org
rspec-ee unit pg11 3/10

00:19:34

passed #746753738
gitlab-org
rspec-ee unit pg11 4/10

00:15:44

passed #746753739
gitlab-org
rspec-ee unit pg11 5/10

00:20:03

passed #746753740
gitlab-org
rspec-ee unit pg11 6/10

00:17:47

passed #746753741
gitlab-org
rspec-ee unit pg11 7/10

00:19:33

passed #746753742
gitlab-org
rspec-ee unit pg11 8/10

00:20:38

passed #746753743
gitlab-org
rspec-ee unit pg11 9/10

00:17:55

passed #746753756
gitlab-org
rspec-ee unit pg11 geo 1/2

00:15:21

passed #746753757
gitlab-org
rspec-ee unit pg11 geo 2/2

00:15:52

passed #746753765
gitlab-org
run-dev-fixtures

00:06:31

passed #746753768
gitlab-org
run-dev-fixtures-ee

00:06:52

passed #746753675
gitlab-org
secrets-sast

00:04:38

passed #746753677
gitlab-org
static-analysis 1/4

00:17:10

passed #746753678
gitlab-org
static-analysis 2/4

00:09:14

passed #746753679
gitlab-org
static-analysis 3/4

00:35:20

passed #746753680
gitlab-org
static-analysis 4/4

00:07:59

passed #746753764
gitlab-org
verify-tests-yml

00:01:27

passed #746753666
gitlab-org
webpack-dev-server

00:05:28

 
  Post Test
passed #746753770
gitlab-org
coverage-frontend

00:03:20

73.8%
skipped #746753772
gitlab-org
fail-pipeline-early
passed #746753771
gitlab-org
rspec:coverage

00:06:45

94.35%
 
  Review Prepare
manual #746753773
gitlab-org allowed to fail manual
review-build-cng
 
  Review
manual #746753775
gitlab-org allowed to fail manual
review-deploy
 
  Qa
manual #746753776
prm allowed to fail manual
package-and-qa
manual #746753783
gitlab-org allowed to fail manual
review-performance
manual #746753778
gitlab-org-docker allowed to fail manual
review-qa-all 1/5
manual #746753779
gitlab-org-docker allowed to fail manual
review-qa-all 2/5
manual #746753780
gitlab-org-docker allowed to fail manual
review-qa-all 3/5
manual #746753781
gitlab-org-docker allowed to fail manual
review-qa-all 4/5
manual #746753782
gitlab-org-docker allowed to fail manual
review-qa-all 5/5
manual #746753777
gitlab-org-docker allowed to fail manual
review-qa-smoke
 
  Post Qa
manual #746753785
gitlab-org allowed to fail manual
parallel-spec-reports
manual #746753784
gitlab-org allowed to fail manual
review-stop