Default on :scan_execution_rule_mode feature flag
What does this MR do and why?
Describe in detail what your merge request does and why.
Default on :scan_execution_rule_mode feature flag
- the feature flag has been on in production for several days now without incident
Changelog: changed
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
master branch |
current branch |
---|---|
![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Upload a GitLab Ultimate license
- Run
echo "Feature.remove(:scan_execution_rule_mode)" | rails c
- Navigate to http://gdk.test:3443/flightjs/Flight/-/security/policies/new?type=scan_execution_policy
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #359883 (closed)
Merge request reports
Activity
changed milestone to %15.5
assigned to @aturinske
added devopsgovern groupsecurity policies sectionsec labels
- Resolved by Etienne Baqué
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Alexander Turinske
@ebaque can you review this? Thanks
requested review from @ebaque
assigned to @arfedoro
Allure report
allure-report-publisher
generated test report!e2e-package-and-test:
test report for 7259ebb1expand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Plan | 59 | 55 | 0 | 62 | 114 | ❌ | | Create | 244 | 76 | 10 | 88 | 330 | ❌ | | Verify | 74 | 12 | 16 | 16 | 102 | ❌ | | Manage | 120 | 60 | 26 | 72 | 206 | ❌ | | Secure | 0 | 46 | 0 | 46 | 46 | ❌ | | Version sanity check | 0 | 0 | 2 | 2 | 2 | ➖ | | Release | 8 | 0 | 0 | 0 | 8 | ✅ | | Configure | 0 | 0 | 6 | 0 | 6 | ➖ | | Fulfillment | 2 | 2 | 24 | 2 | 28 | ❌ | | Analytics | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 6 | 0 | 6 | ➖ | | Protect | 0 | 4 | 0 | 4 | 4 | ❌ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 511 | 255 | 90 | 292 | 856 | ❌ | +----------------------+--------+--------+---------+-------+-------+--------+
Setting label(s) Category:Security Policy Management based on groupsecurity policies.
added Category:Security Policy Management label
removed [deprecated] Accepting merge requests label
@ebaque
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
enabled an automatic merge when the pipeline for fc1e85f6 succeeds
mentioned in commit b40e24c6
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1521 (merged)
added releasedpublished label and removed releasedcandidate label