Skip to content
Snippets Groups Projects

Default on :scan_execution_rule_mode feature flag

Merged Alexander Turinske requested to merge 359883-default-on-scan-execution-rule-mode-ff into master
All threads resolved!

What does this MR do and why?

Describe in detail what your merge request does and why.

Default on :scan_execution_rule_mode feature flag

  • the feature flag has been on in production for several days now without incident

Changelog: changed

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

master branch current branch
Screen_Shot_2022-09-29_at_2.34.24_PM Screen_Shot_2022-09-29_at_2.34.50_PM

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Upload a GitLab Ultimate license
  2. Run echo "Feature.remove(:scan_execution_rule_mode)" | rails c
  3. Navigate to http://gdk.test:3443/flightjs/Flight/-/security/policies/new?type=scan_execution_policy

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #359883 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 1 Warning
    :warning:

    featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.

    For more information, see:

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Alexander Turinske marked this merge request as ready

    marked this merge request as ready

  • Alexander Turinske requested review from @ebaque

    requested review from @ebaque

  • Allure report

    allure-report-publisher generated test report!

    e2e-package-and-test: :x: test report for 7259ebb1

    expand test summary
    +---------------------------------------------------------------------------+
    |                              suites summary                               |
    +----------------------+--------+--------+---------+-------+-------+--------+
    |                      | passed | failed | skipped | flaky | total | result |
    +----------------------+--------+--------+---------+-------+-------+--------+
    | Plan                 | 59     | 55     | 0       | 62    | 114   | ❌     |
    | Create               | 244    | 76     | 10      | 88    | 330   | ❌     |
    | Verify               | 74     | 12     | 16      | 16    | 102   | ❌     |
    | Manage               | 120    | 60     | 26      | 72    | 206   | ❌     |
    | Secure               | 0      | 46     | 0       | 46    | 46    | ❌     |
    | Version sanity check | 0      | 0      | 2       | 2     | 2     | ➖     |
    | Release              | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Configure            | 0      | 0      | 6       | 0     | 6     | ➖     |
    | Fulfillment          | 2      | 2      | 24      | 2     | 28    | ❌     |
    | Analytics            | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Package              | 0      | 0      | 6       | 0     | 6     | ➖     |
    | Protect              | 0      | 4      | 0       | 4     | 4     | ❌     |
    +----------------------+--------+--------+---------+-------+-------+--------+
    | Total                | 511    | 255    | 90      | 292   | 856   | ❌     |
    +----------------------+--------+--------+---------+-------+-------+--------+
  • Etienne Baqué approved this merge request

    approved this merge request

  • :wave: @ebaque, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • 🤖 GitLab Bot 🤖 added 1 deleted label

    added 1 deleted label

  • Etienne Baqué resolved all threads

    resolved all threads

  • Etienne Baqué enabled an automatic merge when the pipeline for fc1e85f6 succeeds

    enabled an automatic merge when the pipeline for fc1e85f6 succeeds

  • Etienne Baqué mentioned in commit b40e24c6

    mentioned in commit b40e24c6

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading