Skip to content
Snippets Groups Projects

Add 'location.file' to new vulnerability details component

All threads resolved!

What does this MR do and why?

Adds the finding's file location to the new, GraphQL-only details component. The file is rendered within a separate section "Location", which is also added.

Screenshots or screen recordings

Screen_Shot_2022-09-19_at_7.16.53_pm

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #371722 (closed)

Edited by David Pisek

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • David Pisek added 186 commits

    added 186 commits

    Compare with previous version

  • David Pisek added 29 commits

    added 29 commits

    Compare with previous version

  • 80 108 </details-section-list-item>
    81 109 </template>
    82 110 </details-section>
    111
    112 <details-section v-if="location" :heading="$options.i18n.locationHeading">
    113 <template #list>
    114 <details-section-list-item v-if="location.file" :label="$options.i18n.locationFileLabel">
  • David Pisek added 1 commit

    added 1 commit

    • 00a30d7f - WIP: add location-file specs

    Compare with previous version

  • 27 27 name: 'GitLab.com',
    28 28 webUrl: 'http://gitlab.com',
    29 29 },
    30 location: {
    31 // @TODO: confirm data
  • David Pisek changed title from Draft: Resolve "[Pipeline Sec - GraphQL migration]: Render existing GraphQL fields in new details component" to Draft: Add 'location.file' to new vulnerability details component

    changed title from Draft: Resolve "[Pipeline Sec - GraphQL migration]: Render existing GraphQL fields in new details component" to Draft: Add 'location.file' to new vulnerability details component

  • David Pisek changed the description

    changed the description

  • David Pisek
  • David Pisek added 1 commit

    added 1 commit

    Compare with previous version

  • David Pisek requested review from @sming-gitlab

    requested review from @sming-gitlab

  • David Pisek added 1 commit

    added 1 commit

    Compare with previous version

  • David Pisek marked this merge request as ready

    marked this merge request as ready

  • David Pisek added 139 commits

    added 139 commits

    Compare with previous version

  • Samantha Ming
  • Samantha Ming approved this merge request

    approved this merge request

  • Samantha Ming removed review request for @sming-gitlab

    removed review request for @sming-gitlab

  • :wave: @sming-gitlab, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • David Pisek added 68 commits

    added 68 commits

    Compare with previous version

  • David Pisek added 121 commits

    added 121 commits

    Compare with previous version

  • 🤖 GitLab Bot 🤖 changed milestone to %15.5

    changed milestone to %15.5

  • David Pisek added 40 commits

    added 40 commits

    Compare with previous version

  • David Pisek added 1 commit

    added 1 commit

    Compare with previous version

  • David Pisek added 1 commit

    added 1 commit

    • 4d9c9ece - Feedback: Add specs to cover line range link

    Compare with previous version

  • David Pisek requested review from @svedova

    requested review from @svedova

  • Savas Vedova approved this merge request

    approved this merge request

  • Savas Vedova resolved all threads

    resolved all threads

  • merged

  • Savas Vedova mentioned in commit f8852d6b

    mentioned in commit f8852d6b

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading