Add iteration support for work items
What does this MR do and why?
This MR adds the work items iterations widget, using the UI mockups #367456 (designs)
Screenshots or screen recordings
Screenshots | Screenshots |
---|---|
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Enable the feature flag
Feature.enable(:work_items) Feature.enable(:work_items_mvc_2)
- Make sure you are on the
ee
version of GitLab to check the iteration capability of work items - Open any issue without any iteration
- Create a task from the issue(by click the add button from the tasks section of the issue)
- Now Open the task in the modal/full view , see that no iteration is associated with the task
- Now try to manually edit the iteration by choosing from the list when you focus on the input
- See that the iteration is assigned to the task
- Try creating the a new task from an issue already having an iteration associated with it
- check that the task created has the iteration of the parent ( in this case issue )
- You can also manually edit the iteration even when it is already associated with the task on. creation
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
Check for canUpdate of iteration - different text -
mobile version of the view -
Check the /new route version for work_items - created without any parent , no iteration associated
Merge request reports
Activity
assigned to @deepika.guliani
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @mayra-cabrera
,@dbalexandre
,@marin
,@dzaporozhets
,@psimyn
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Bot- A deleted user
added frontend label
11 Warnings This merge request is quite big (1018 lines changed), please consider splitting it into multiple merge requests. 37fecf79: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 5abf7abf: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 5abf7abf: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. df76acea: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. b41bebce: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. b41bebce: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 3220b849: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 3220b849: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 0c162956: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. fd9257d6: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 2 Messages CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
doc/user/tasks.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Drew Blessing ( @dblessing
) (UTC-5, 10.5 hours behind@deepika.guliani
)George Koltsov ( @georgekoltsov
) (UTC+1, 4.5 hours behind@deepika.guliani
)frontend Paul Gascou-Vaillancourt ( @pgascouvaillancourt
) (UTC-4, 9.5 hours behind@deepika.guliani
)Simon Knox ( @psimyn
) (UTC+11, 5.5 hours ahead of@deepika.guliani
)UX Camellia X. YANG ( @cam.x
) (UTC+0, 5.5 hours behind@deepika.guliani
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@deepika.guliani - please see the following guidance and update this merge request.1 Error, 1 Warning Please add typebug typefeature, or typemaintenance label to this merge request. Please add a subtype label to this merge request. If you have added a type label and do not feel the purpose of this merge request matches one of the subtypes labels, please resolve this discussion.
Edited by 🤖 GitLab Bot 🤖
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 5a890861 and d403d565
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.59 MB 3.59 MB - 0.0 % mainChunk 1.96 MB 1.96 MB - 0.0 %
Note: We do not have exact data for 5a890861. So we have used data from: 3889d44c.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa-blocking:
test report for d0a16c97expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Create | 27 | 0 | 2 | 26 | 29 | ❗ | | Plan | 47 | 0 | 1 | 47 | 48 | ❗ | | Manage | 57 | 0 | 3 | 56 | 60 | ❗ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Verify | 12 | 0 | 1 | 11 | 13 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Secure | 2 | 0 | 0 | 2 | 2 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 156 | 0 | 10 | 144 | 166 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for d403d565expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Verify | 12 | 0 | 1 | 0 | 13 | ✅ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 53 | 0 | 4 | 0 | 57 | ✅ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Manage | 52 | 0 | 8 | 3 | 60 | ❗ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Secure | 2 | 0 | 0 | 0 | 2 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 158 | 0 | 17 | 3 | 175 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
Setting label groupproject management based on
@deepika.guliani
's group.added groupproject management label
added devopsplan sectiondev labels
added 442 commits
-
0d459e0b...45140eee - 441 commits from branch
master
- 98989f5e - Add iteration to work item widgets
-
0d459e0b...45140eee - 441 commits from branch
- A deleted user
added backend label
mentioned in issue #367456 (closed)
added UX label
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
added 223 commits
-
98989f5e...4b030e49 - 221 commits from branch
master
- 5cde3ef4 - Add iteration to work item widgets
- 6b9955c9 - Apollo query for fetching iteration cadences
-
98989f5e...4b030e49 - 221 commits from branch
added 1 commit
- 65b01a9c - Add dropdown for grouping cadences and project query
added 223 commits
-
65b01a9c...2f435fd6 - 217 commits from branch
master
- 5a0b0874 - Add iteration to work item widgets
- 1632fff6 - Apollo query for fetching iteration cadences
- d0c186f7 - Call update work item mutation with hardcoded iteration
- f9bea014 - Call update work item mutation with hardcoded iteration
- 97fce87a - Add dropdown for grouping cadences and project query
- 8f280c98 - Add the iteration of the parent while creating tasks
Toggle commit list-
65b01a9c...2f435fd6 - 217 commits from branch