Add curly brackets to fix the matcher in ruby 3
What does this MR do and why?
https://gitlab.com/gitlab-org/gitlab/-/jobs/2967128983
This spec fails in Ruby 3 due to the way rspec-mocks
handles hash vs kwargs matching.
Similar to !86157 (merged), see this MR for more context
How to set up and validate locally
Run the spec in both Ruby 2.7.5 (regular way) and Ruby 3.0.4, both should pass
You can run specs in ruby 3 by:
- Executing
asdf local ruby 3.0.4
- Run the spec
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #372413 (closed)
Merge request reports
Activity
changed milestone to %15.4
assigned to @rzwambag
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @engwan
,@stanhu
,@eread
,@allison.browne
,@nmalcolm
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Valery Sizov ( @vsizov
) (UTC+1, 1 hour behind@rzwambag
)Marc Shaw ( @marc_shaw
) (UTC+2, same timezone as@rzwambag
)~"codeowners" Reviewer review is optional for ~"codeowners" Jacob Vosmaer ( @jacobvosmaer-gitlab
) (UTC+2, same timezone as@rzwambag
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Matthias Käppler
Hi @sam.figueroa could you take a look at this MR? It should fix the spec in Ruby 3
requested review from @sam.figueroa
Ruby 3 pipeline (green specs): https://gitlab.com/gitlab-org/gitlab/-/pipelines/629507360
Edited by Roy Zwambag@sam.figueroa
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
removed review request for @sam.figueroa
requested review from @mkaeppler
mentioned in commit 3c0a5f97
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label