Revert "Merge branch 'a_mcdonald-master-patch-46738' into 'master'"
What does this MR do and why?
Fixes #372186 (closed)
The test was updated after !95859 (merged) updated the Content-Type
.
However a follow up MR !96398 (merged) adds an exception for SVGs so we should expect to get a Content-Type: image/svg+xml
response in this spec.
This MR reverts the test back to the original state.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
added Quality maintenancerefactor typemaintenance labels
assigned to @john.mcdonnell
/cc @a_mcdonald
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @grzesiek
,@mlapierre
,@ddavison
,@a_mcdonald
,@at.ramya
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
mentioned in issue #372186 (closed)
- A deleted user
added QA label
1 Warning This merge request does not refer to an existing milestone. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer QA Désirée Chevalier ( @dchevalier2
) (UTC-4, 16 hours behind@john.mcdonnell
)Dan Davison ( @ddavison
) (UTC-4, 16 hours behind@john.mcdonnell
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerchanged milestone to %15.4
Allure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for 2da7eaf6expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Plan | 47 | 0 | 1 | 12 | 48 | ❗ | | Manage | 46 | 0 | 3 | 20 | 49 | ❗ | | Verify | 12 | 0 | 1 | 10 | 13 | ❗ | | Create | 28 | 0 | 1 | 13 | 29 | ❗ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Secure | 2 | 0 | 0 | 2 | 2 | ❗ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Protect | 2 | 0 | 0 | 1 | 2 | ❗ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 146 | 0 | 9 | 58 | 155 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
review-qa-all:
test report for 2da7eaf6expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 33 | 2 | 3 | 11 | 38 | ❌ | | Manage | 45 | 2 | 3 | 14 | 50 | ❌ | | Create | 120 | 6 | 8 | 44 | 134 | ❌ | | Secure | 13 | 7 | 1 | 6 | 21 | ❌ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | | Fulfillment | 0 | 0 | 13 | 0 | 13 | ➖ | | Plan | 6 | 0 | 3 | 0 | 9 | ✅ | | Analytics | 1 | 0 | 1 | 0 | 2 | ✅ | | Release | 4 | 0 | 0 | 0 | 4 | ✅ | | Configure | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 222 | 17 | 36 | 75 | 275 | ❌ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 2da7eaf6expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Create | 10 | 0 | 0 | 5 | 10 | ❗ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 10 | 0 | 0 | 5 | 10 | ❗ | +--------+--------+--------+---------+-------+-------+--------+
mentioned in commit 789029c0
mentioned in issue gitlab-org/quality/pipeline-triage#159 (closed)
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added pipelineexpedited label