Skip to content
Snippets Groups Projects

Optimise shared chat integration spec examples

Merged Luke Duncalfe requested to merge ld-speed-up-chat-notification-shared-examples into master
All threads resolved!

What does this MR do and why?

This MR optimises the shared chat integration spec examples.

These shared examples are included in 5 "chat integration" specs.

Locally, this optimisation is benchmarked as reducing the time these shared examples take by ~85%, for each of the 5 specs that include them.

# One of the shared examples:
bundle exec spring rspec spec/models/integrations/discord_spec.rb:6

# This branch
Finished in 24.73 seconds (files took 1.56 seconds to load)

# master
Finished in 4 minutes 10.5 seconds (files took 1.49 seconds to load)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Luke Duncalfe

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Author Maintainer

    Hi @joseph! Could you please give this MR its first backend review? Thank you!

  • Luke Duncalfe requested review from @joseph

    requested review from @joseph

  • Luke Duncalfe changed the description

    changed the description

  • Thank you for this, @.luke. In my environment, execution time has reduced by 50%.

  • Joseph Wambua approved this merge request

    approved this merge request

  • Joseph Wambua requested review from @john-mason and removed review request for @joseph

    requested review from @john-mason and removed review request for @joseph

  • :wave: @joseph, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • Luke Duncalfe resolved all threads

    resolved all threads

  • mentioned in issue #370921 (closed)

  • John Mason approved this merge request

    approved this merge request

  • John Mason requested review from @kerrizor and removed review request for @john-mason

    requested review from @kerrizor and removed review request for @john-mason

  • Kerri Miller approved this merge request

    approved this merge request

  • Kerri Miller resolved all threads

    resolved all threads

  • Kerri Miller enabled an automatic merge when the pipeline for d281f963 succeeds

    enabled an automatic merge when the pipeline for d281f963 succeeds

  • merged

  • Kerri Miller mentioned in commit 1c17dbaa

    mentioned in commit 1c17dbaa

  • added workflowstaging label and removed workflowcanary label

  • 🤖 GitLab Bot 🤖 added devopsmanage label and removed 1 deleted label

    added devopsmanage label and removed 1 deleted label

  • Please register or sign in to reply
    Loading