Optimise shared chat integration spec examples
What does this MR do and why?
This MR optimises the shared chat integration spec examples.
These shared examples are included in 5 "chat integration" specs.
Locally, this optimisation is benchmarked as reducing the time these shared examples take by ~85%
, for each of the 5 specs that include them.
# One of the shared examples:
bundle exec spring rspec spec/models/integrations/discord_spec.rb:6
# This branch
Finished in 24.73 seconds (files took 1.56 seconds to load)
# master
Finished in 4 minutes 10.5 seconds (files took 1.49 seconds to load)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.3
added backend groupintegrations [DEPRECATED] maintenancerefactor labels
assigned to @.luke
added typemaintenance label
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @mwoolf
,@toupeira
,@engwan
,@pshutsin
,@a_mcdonald
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Serena Fang ( @serenafang
) (UTC-5, 17 hours behind@.luke
)Kerri Miller ( @kerrizor
) (UTC-7, 19 hours behind@.luke
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerSetting label(s) devopsecosystem sectiondev based on ~"group::integrations".
added sectiondev + 1 deleted label
added 681 commits
-
206cb002...764383a6 - 679 commits from branch
master
- 6179e145 - Optimise shared chat integration spec examples
- b19c7d9e - Only create pipelines for tests that need it
-
206cb002...764383a6 - 679 commits from branch
- Resolved by Luke Duncalfe
requested review from @joseph
Thank you for this, @.luke. In my environment, execution time has reduced by 50%.
requested review from @john-mason and removed review request for @joseph
@joseph
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
- Resolved by Kerri Miller
Hi @john-mason! Could you please review this MR, roulette has picked you! (This is my first review so a second opinion is welcome
)Edited by Joseph Wambua
mentioned in issue #370921 (closed)
requested review from @kerrizor and removed review request for @john-mason
enabled an automatic merge when the pipeline for d281f963 succeeds
mentioned in commit 1c17dbaa
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added devopsmanage label and removed 1 deleted label
added groupimport and integrate label and removed groupintegrations [DEPRECATED] label