Avoid usage of toBeTruthy/toBeFalsy in /project_rules_spec.js
What does this MR do and why?
This MR aims to resolve the issue #369707 (closed)
Merge request reports
Activity
Hey @anshulriyal!
👋 Thank you for your contribution to GitLab. Please refer to the contribution flow documentation for a quick overview of the process, and the merge request (MR) guidelines for the detailed process.
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help moving the MR forward, feel free to post
@gitlab-bot help
. Read more on how to get help.To enable automated checks on your MR, please configure Danger for your fork.
You can comment
@gitlab-bot label <label1> <label2>
to add labels to your MR. Please see the list of allowed labels in thelabel
command documentation.This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
assigned to @anshulriyal
This merge request will be considered part of the quarterly GitLab Hackathon for a chance to win a prize.
Can you make sure this merge request mentions or links to the relevant issue that it's attempting to close?
Thank you for your contribution!
This message was generated automatically. You're welcome to improve it.
added Hackathon label
@gitlab-bot ready
added workflowready for review label and removed workflowin dev label
@justin_ho
, this Community contribution is ready for review.- Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
- Add the workflowin dev label if the merge request needs action from the author. This message was generated automatically. You're welcome to improve it.
requested review from @justin_ho
- Resolved by Zack Cuddy
requested review from @zcuddy and removed review request for @justin_ho
- Resolved by Zack Cuddy
👋 @justin_ho
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, please start a new pipeline before merging.
For more info, please refer to the following links:
added frontend maintenancerefactor typemaintenance + 1 deleted label
@zcuddy, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline finished more than 2 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to merge when pipeline succeeds.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
@anshulriyal, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:
- Leave a
👍 or a👎 on this comment to describe your experience. - Create a new comment starting with
@gitlab-bot feedback
below, and leave any additional feedback you have for us in the comment.
Have five minutes? Take our survey to give us even more feedback on how GitLab can improve the contributor experience.
Thanks for your help!
❤ This message was generated automatically. You're welcome to improve it.
- Leave a
mentioned in commit 208543a7
added workflowstaging-canary label and removed workflowready for review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
changed milestone to %15.3
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label