Turned on apollo dev tools
What does this MR do and why?
Either Apollo Client isn't running in dev mode for us, or Apollo's connection to devtools is not working correctly. Either way, this MR allows us to use the Apollo Client devtools everywhere except for on production.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @donaldcook
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @rspeicher
,@iamphill
,@kushalpandya
,@filipa
,@ntepluhina
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
- A deleted user
added frontend label
4 Warnings ⚠ This merge request changed files with disabled eslint rules. Please consider fixing them. ⚠ You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.⚠ Please add a merge request subtype to this merge request. ⚠ This merge request does not refer to an existing milestone. 1 Message 📖 CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Disabled eslint rules
The following files have disabled
eslint
rules. Please consider fixing them:app/assets/javascripts/lib/graphql.js
Run the following command for more details
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \ 'app/assets/javascripts/lib/graphql.js'
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Justin Ho ( @justin_ho
) (UTC+7, 14 hours ahead of@donaldcook
)Paul Slaughter ( @pslaughter
) (UTC-5, 2 hours ahead of@donaldcook
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 Danger- Resolved by Natalia Tepluhina
@ntepluhina I had the Apollo dev tools installed but never used it because I thought it was broken. But I really needed to see the Apollo cache so tried it again, but found I had to turn it on.
- Is there a reason to not turn it on for everyone?
- Is there another way to inspect the Apollo cache?
- Resolved by 🤖 GitLab Bot 🤖
👋 @donaldcook - please add typebug typefeature, typemaintenance or a subtype label to this merge request.- typebug: Defects in shipped code and fixes for those defects. This includes all the bug types (availability, performance, security vulnerability, mobile, etc.)
- typefeature: Effort to deliver new features, feature changes & improvements. This includes all changes as part of new product requirements like application limits.
- typemaintenance: Up-keeping efforts & catch-up corrective improvements that are not Features nor Bugs. This includes restructuring for long-term maintainability, stability, reducing technical debt, improving the contributor experience, or upgrading dependencies.
See the handbook for more guidance on classifying.
This message was created with automation and Engineering Productivity is looking for feedback in this issue:
https://gitlab.com/gitlab-org/quality/engineering-productivity/team/-/issues/43
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits b16fbcd2 and 482b310d
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.49 MB 3.49 MB - 0.0 % mainChunk 1.9 MB 1.9 MB - 0.0 %
Note: We do not have exact data for b16fbcd2. So we have used data from: 44a8c611.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 DangerAllure report
allure-report-publisher
generated test report!review-qa-blocking:
❗ test report for b3a83a5dexpand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Create | 28 | 0 | 1 | 28 | 29 | ❗ | | Plan | 47 | 0 | 1 | 47 | 48 | ❗ | | Manage | 34 | 0 | 2 | 36 | 36 | ❗ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | | Verify | 14 | 0 | 1 | 14 | 15 | ❗ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Feature flag handler sanity checks | 9 | 0 | 0 | 9 | 9 | ❗ | | Secure | 2 | 0 | 0 | 2 | 2 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 136 | 0 | 7 | 138 | 143 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
added devopsplan groupproject management typemaintenance labels
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
requested review from @ntepluhina
added sectiondev label
👋 @ntepluhina
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
added 528 commits
-
b3a83a5d...b16fbcd2 - 527 commits from branch
master
- 482b310d - Turned on apollo dev tools
-
b3a83a5d...b16fbcd2 - 527 commits from branch
enabled an automatic merge when the pipeline for 09292e6e succeeds
mentioned in commit 66b4cf58
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label