Skip to content

Fix project avatar identicons contrast in dark mode

Dannyel Cardoso da Fonseca requested to merge dannyelcf/gitlab:369554-dcf-One-of-the-project-avatar-identicons-does-not-have-enough-contrast-in-dark-mode into master

What does this MR do and why?

Fix the indigo color background (gl-avatar-identicon-bg3 and gl-avatar-identicon-bg3) applied in project avatar identicons.

Context

In the Gitlab UI project, in the avatar.scss file the variable $gl-avatar-identicon-bgs is set to use $theme-indigo-50 as the 3rd background option:

$gl-avatar-identicon-bgs: $red-50, $purple-50, $theme-indigo-50, $blue-50, $green-50, $orange-50,
  $gray-50;

In the Gitlab project, in the _dark.scss file is lacking the definition of $theme-indigo-50. This makes the default $theme-indigo-50 color be used instead of its dark color.

Screenshots or screen recordings

Before After
image image

How to set up and validate locally

  1. Run gdk start.
  2. Access http://localhost:3000/.
  3. Go to the project dashboard.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #369554 (closed)

Edited by Dannyel Cardoso da Fonseca

Merge request reports