Fix accidental assignment in spec
What does this MR do and why?
This fixes an accidential assignment in a spec.
See:
- gitlab-org/ruby/gems/gitlab-styles#38 (comment 1046354315)
- https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/2526#note_1043311383
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @.luke
added groupintegrations [DEPRECATED] typemaintenance labels
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @mwoolf
,@reprazent
,@toupeira
,@alexkalderimis
,@agarciatesares
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
@splattael thanks for noticing gitlab-org/ruby/gems/gitlab-styles#38 (comment 1046354315)!
changed milestone to %15.3
1 Warning Please add a merge request subtype to this merge request. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer test for spec/features/*
Tarun Vellishetty ( @tvellishetty
) (UTC+5.5, 6.5 hours behind@.luke
)Maintainer review is optional for test for spec/features/*
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by charlie ablett
@cablett Could you please review this small spec bug fix? Thank you!
requested review from @cablett
added workflowin review label
Great spotting @.luke - LGTM
New pipe started and MWPS set
enabled an automatic merge when the pipeline for 38a49776 succeeds
@cablett
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
mentioned in commit eb7288b5
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added maintenancetest-gap label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added groupimport and integrate label and removed groupintegrations [DEPRECATED] label