Skip to content
Snippets Groups Projects

Update docker example for DAST

Merged Zane Chua requested to merge zanechua/gitlab:zanechua-master-patch-53985 into master
All threads resolved!

What does this MR do and why?

I am pretty sure the docker example needs the services to be under the dast stage otherwise the pipeline will try to boot the service when the image hasn't even been built

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Zane Chua

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Mayra Cabrera requested review from @craigmsmith and removed review request for @mayra-cabrera

    requested review from @craigmsmith and removed review request for @mayra-cabrera

  • Craig Smith requested review from @idawson

    requested review from @idawson

  • Craig Smith approved this merge request

    approved this merge request

  • Craig Smith requested review from @rdickenson

    requested review from @rdickenson

  • Russell Dickenson approved this merge request

    approved this merge request

  • Russell Dickenson resolved all threads

    resolved all threads

  • Suggested Reviewers (beta)

    The individuals below may be good candidates to participate in the review based on various factors.

    You can use slash commands in comments to quickly assign /assign_reviewer @user1.

    Suggested Reviewers
    @rspeicher, @aqualls, @marin, @marcel.amirault, @kushalpandya

    If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

    Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".

  • 1 Warning
    :warning: This merge request does not refer to an existing milestone.
    1 Message
    :book: This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge.

    Documentation review

    The following files require a review from a technical writer:

    • doc/user/application_security/dast/index.md

    The review does not need to block merging this merge request. See the:

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • @zanechua, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:

    1. Leave a :thumbsup: or a :thumbsdown: on this comment to describe your experience.
    2. Create a new comment starting with @gitlab-bot feedback below, and leave any additional feedback you have for us in the comment.

    Have five minutes? Take our survey to give us even more feedback on how GitLab can improve the contributor experience.

    Thanks for your help! :heart:

    This message was generated automatically. You're welcome to improve it.

  • mentioned in commit d2c11b9b

  • Russell Dickenson changed milestone to %15.2

    changed milestone to %15.2

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading