Remove `group_name_path_vue` feature flag
What does this MR do and why?
Related to #363623 (closed)
In !88085 (merged) and !90295 (merged) we refactored the Group name
and Group URL
fields that are shown when creating a group, importing a group, or creating/editing a group in the Admin area from HAML/jQuery to Vue. The refactor has now been enabled for all of %15.2 so we would like to remove the feature flag.
Unfortunately there are still a couple of places that still use the jQuery so we can't yet remove that but I have created #367564 as a follow-up.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.2
added devopsmanage feature flag featureaddition frontend missed:15.1 sectiondev typefeature workflowin dev + 1 deleted label
assigned to @peterhegman
removed workflowin dev label
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @marin
,@dbalexandre
,@dzaporozhets
,@mayra-cabrera
,@seanarnold
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Bot- A deleted user
added backend label
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Tarun Vellishetty ( @tvellishetty
) (UTC+5.5, 12.5 hours ahead of@peterhegman
)Jan Provaznik ( @jprovaznik
) (UTC+2, 9 hours ahead of@peterhegman
)frontend Tomas Vik ( @viktomas
) (UTC+2, 9 hours ahead of@peterhegman
)Ezekiel Kigbo ( @ekigbo
) (UTC+10, 17 hours ahead of@peterhegman
)QA Harsha Muralidhar ( @hmuralidhar
) (UTC+5.5, 12.5 hours ahead of@peterhegman
)Maintainer review is optional for QA test for spec/features/*
Valerie Burton ( @vburton
) (UTC-5, 2 hours ahead of@peterhegman
)Maintainer review is optional for test for spec/features/*
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- A deleted user
added QA label
Allure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for ae0a0cc3expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Manage | 38 | 0 | 2 | 39 | 40 | ❗ | | Create | 23 | 0 | 2 | 23 | 25 | ❗ | | Plan | 47 | 0 | 1 | 47 | 48 | ❗ | | Verify | 12 | 0 | 1 | 12 | 13 | ❗ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Secure | 2 | 0 | 0 | 2 | 2 | ❗ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 133 | 0 | 9 | 125 | 142 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
package-and-qa-ff-deleted:
test report for ae0a0cc3expand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Create | 450 | 0 | 18 | 9 | 468 | ❗ | | Plan | 162 | 0 | 0 | 0 | 162 | ✅ | | Verify | 120 | 0 | 9 | 0 | 129 | ✅ | | Secure | 63 | 0 | 6 | 3 | 69 | ❗ | | Manage | 321 | 0 | 9 | 6 | 330 | ❗ | | Configure | 0 | 0 | 9 | 0 | 9 | ➖ | | Product Intelligence | 6 | 0 | 0 | 0 | 6 | ✅ | | Fulfillment | 6 | 0 | 33 | 0 | 39 | ✅ | | Package | 0 | 0 | 9 | 0 | 9 | ➖ | | Protect | 6 | 0 | 0 | 0 | 6 | ✅ | | Release | 15 | 0 | 0 | 3 | 15 | ❗ | | Version sanity check | 0 | 0 | 3 | 3 | 3 | ➖ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 1149 | 0 | 96 | 24 | 1245 | ❗ | +----------------------+--------+--------+---------+-------+-------+--------+
package-and-qa:
test report for ae0a0cc3expand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Create | 928 | 0 | 37 | 11 | 965 | ❗ | | Secure | 126 | 0 | 12 | 4 | 138 | ❗ | | Manage | 658 | 0 | 18 | 9 | 676 | ❗ | | Verify | 242 | 0 | 18 | 0 | 260 | ✅ | | Plan | 332 | 0 | 0 | 0 | 332 | ✅ | | Fulfillment | 14 | 0 | 67 | 0 | 81 | ✅ | | Package | 161 | 0 | 21 | 26 | 182 | ❗ | | Version sanity check | 0 | 0 | 6 | 3 | 6 | ➖ | | Release | 30 | 0 | 0 | 4 | 30 | ❗ | | Configure | 1 | 0 | 18 | 0 | 19 | ✅ | | Protect | 12 | 0 | 0 | 0 | 12 | ✅ | | Enablement:Search | 9 | 0 | 1 | 0 | 10 | ✅ | | Product Intelligence | 13 | 0 | 0 | 0 | 13 | ✅ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 2526 | 0 | 198 | 57 | 2724 | ❗ | +----------------------+--------+--------+---------+-------+-------+--------+
- The
gitlab-qa-mirror
downstream pipeline for !92252 (ae0a0cc3) failed! - The
gitlab-qa-mirror
downstream pipeline for !92252 (ae0a0cc3) failed! - The
gitlab-qa-mirror
downstream pipeline for !92252 (ae0a0cc3) failed! - The
gitlab-qa-mirror
downstream pipeline for !92252 (ae0a0cc3) passed.
- The
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
added maintenancerefactor typemaintenance labels and removed typefeature label
removed missed:15.1 label
@bhrai can you please review the backend changes when you have time?
@pgascouvaillancourt can you please review the frontend changes when you have time?
requested review from @bhrai and @pgascouvaillancourt
- Resolved by Kushal Pandya
@vburton can you help with the QA review and pipeline here? I am not quite sure what happened to the pipeline
requested review from @vburton
@acunskis can you review feature spec changes? Just removing old specs that were only for when the feature flag was disabled.
requested review from @acunskis
@peterhegman frontend LGTM
@kushalpandya could you have a look please?requested review from @kushalpandya and removed review request for @pgascouvaillancourt
@pgascouvaillancourt
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
mentioned in issue gitlab-org/quality/pipeline-triage#152 (closed)
@kushalpandya, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline finished more than 2 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to merge when pipeline succeeds.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
mentioned in commit 00feee27
added workflowstaging-canary label
removed review request for @bhrai
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in issue gitlab-org/quality/pipeline-triage#153 (closed)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1252 (merged)
mentioned in issue gitlab-org/quality/pipeline-triage#154 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#157 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#158 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#160 (closed)
added devopsdata stores grouptenant scale sectioncore platform labels and removed devopsmanage sectiondev + 1 deleted label