Use paginated tree for the last commit query
What does this MR do and why?
We don't need a tree at all for the last commit, but since the existing paginated tree returns a limited number of entries, we can use it without introducing backend changes
Merge request reports
Activity
changed milestone to %15.2
added Category:Source Code Management backend groupsource code labels
assigned to @igor.drozdov
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @nick.thomas
,@rspeicher
,@reprazent
,@ntepluhina
,@engwan
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Bot- A deleted user
added bugperformance frontend typebug labels
1 Warning This merge request changed files with disabled eslint rules. Please consider fixing them. Disabled eslint rules
The following files have disabled
eslint
rules. Please consider fixing them:app/assets/javascripts/repository/components/last_commit.vue
Run the following command for more details
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \ 'app/assets/javascripts/repository/components/last_commit.vue'
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Manoj Memana Jayakumar ( @manojmj
) (UTC+2, same timezone as@igor.drozdov
)Kerri Miller ( @kerrizor
) (UTC-7, 9 hours behind@igor.drozdov
)frontend Mireya Andres ( @mgandres
) (UTC+8, 6 hours ahead of@igor.drozdov
)Phil Hughes ( @iamphill
) (UTC+1, 1 hour behind@igor.drozdov
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 1 commit
- 938f3456 - Use paginated tree for the last commit query
- Resolved by Igor Drozdov
@vyaklushin could you please have a look at this MR? does it make sense, wdyt? if it does, I'll pass it to the frontend team when build is green
requested review from @vyaklushin
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 12a280b7 and a3ed631e
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.45 MB 3.45 MB - -0.0 % mainChunk 1.88 MB 1.88 MB - 0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for a3ed631eexpand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Create | 23 | 0 | 2 | 23 | 25 | ❗ | | Manage | 38 | 0 | 2 | 40 | 40 | ❗ | | Plan | 47 | 0 | 1 | 47 | 48 | ❗ | | Verify | 12 | 0 | 1 | 12 | 13 | ❗ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Secure | 2 | 0 | 0 | 2 | 2 | ❗ | | Feature flag handler sanity checks | 9 | 0 | 0 | 9 | 9 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 133 | 0 | 9 | 135 | 142 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
Setting label(s) devopscreate sectiondev based on groupsource code.
added devopscreate sectiondev labels
mentioned in issue #367225
- Resolved by Phil Hughes
@anna_vovchenko could you please review this MR from frontend perspective?
requested review from @anna_vovchenko
- Resolved by Phil Hughes
- Resolved by Phil Hughes
- Resolved by Phil Hughes
removed review request for @anna_vovchenko
@anna_vovchenko
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
added 1162 commits
-
938f3456...6ec1ba92 - 1161 commits from branch
master
- a3ed631e - Use paginated tree for the last commit query
-
938f3456...6ec1ba92 - 1161 commits from branch
requested review from @iamphill and removed review request for @vyaklushin
enabled an automatic merge when the pipeline for ec5c53b2 succeeds
mentioned in commit 59b2b704
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1252 (merged)