Add Civo to the create cluster page
What does this MR do and why?
This MR adds Civo logo to the create cluster page. The logo is linked to the documentation page.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Visit Infrastructure -> Kubernetes clusters page
- Select Create a cluster from the actions dropdown
- Verify the page
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Review progress:
Related to #363616 (closed)
Merge request reports
Activity
changed milestone to %15.2
assigned to @anna_vovchenko
removed environmentsparked label
removed documentation label
removed feature label
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @dbalexandre
,@mayra-cabrera
,@marin
,@dzaporozhets
,@tkuah
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Bot- A deleted user
added backend label
2 Warnings featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Piotr Skorupa ( @pskorupa
) (UTC+2, 1 hour behind@anna_vovchenko
)Rémy Coutable ( @rymai
) (UTC+2, 1 hour behind@anna_vovchenko
)frontend Tristan Read ( @tristan.read
) (UTC+12, 9 hours ahead of@anna_vovchenko
)Andrew Fontaine ( @afontaine
) (UTC-4, 7 hours behind@anna_vovchenko
)UX Libor Vanc ( @lvanc
) (UTC-10, 13 hours behind@anna_vovchenko
)Jeremy Elder ( @jeldergl
) (UTC-5, 8 hours behind@anna_vovchenko
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerAllure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for 3403f361expand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Create | 23 | 0 | 2 | 23 | 25 | ❗ | | Verify | 12 | 0 | 1 | 12 | 13 | ❗ | | Manage | 37 | 0 | 2 | 39 | 39 | ❗ | | Plan | 47 | 0 | 1 | 47 | 48 | ❗ | | Secure | 2 | 0 | 0 | 2 | 2 | ❗ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 123 | 0 | 9 | 125 | 132 | ❗ | +----------------------+--------+--------+---------+-------+-------+--------+
added 131 commits
-
87e41a92...57ede98f - 130 commits from branch
master
- f84c3e94 - Added Civo logo to the create cluster page
-
87e41a92...57ede98f - 130 commits from branch
- Resolved by Denys Mishunov
@lvanc, could you please review my MR from the UX perspective?
@jrushford, could you please do the frontend review?
added workflowready for review label and removed workflowin dev label
requested review from @jrushford and @lvanc
@jrushford
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
requested review from @dmishunov and removed review request for @jrushford
marked the checklist item UX review as completed
marked the checklist item UX review as incomplete
marked the checklist item frontend developer review as completed
- Resolved by Anna Vovchenko
@anna_vovchenko Thanks for the mention. There has been a new process introduced for adding third-party logos:
Looking over the third-party trademark tracker, it looks like Civo is not yet complete.
I just created an issue for this https://gitlab.com/gitlab-com/legal-and-compliance/-/issues/961.
Once the logo is approved we should be able to move forward with this MR.
- Resolved by Anna Vovchenko
@anna_vovchenko suggestion: The Civo logo appears larger than the other logos. Is there a way to set a max-width on the logos that appear in these cards?
thought: I have been seeing different variations for how third-party logos are displayed in the UI. I think we should add some guidelines in Pajamas for this.
What do you call this UI component that you are using for these logos?
- Resolved by Anna Vovchenko
- Resolved by Denys Mishunov
removed review request for @dmishunov
- Resolved by Libor Vanc
@anna_vovchenko I just reviewed this using my local GDK and it looks like the image link is broken:
Is there something else I need to do in order to see:
http://127.0.0.1:3000/images/illustrations/third-party-logos/civo.svg
?
mentioned in issue gitlab-org/gitlab-services/design.gitlab.com#1385
added 1 commit
- 3403f361 - Updated spacings and sizings after the review
requested review from @dmishunov
marked the checklist item UX review as completed
marked the checklist item UX review as incomplete
marked the checklist item UX review as completed
marked the checklist item frontend maintainer review as completed
enabled an automatic merge when the pipeline for aef09adf succeeds
mentioned in commit 98b7c92c
added workflowstaging-canary label and removed workflowready for review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label