Card sizing for security dashboard discovery moment experiment

changed milestone to %15.2

added auto updated devopsgrowth groupacquisition sectiongrowth typefeature labels

assigned to @a_akgun

marked this merge request as ready

changed title from Draft: Resolve "Pre-launch followups for Security dashboard discovery moment experiment (#333723)" to Card sizing for security dashboard discovery moment experiment

marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

mentioned in issue #365499

changed the description

added 1031 commits

8833f404...f5b721f8 - 1030 commits from branch master
fa697853 - Security dashboard card sizing

Compare with previous version

@kcomoli could you help me author the security showcase block sizing and placement? (we can get a UX review)

Decisions

The small, medium and large size behavior
The size and location of the buttons

requested review from @kcomoli

Suggested Reviewers (beta)

The individuals below may be good candidates to participate in the review based on various factors.

You can use slash commands in comments to quickly assign /assign_reviewer @user1.

Suggested Reviewers
`@rspeicher`, `@markrian`, `@pgascouvaillancourt`, `@ntepluhina`, `@kushalpandya`

If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".

added frontend label

3 Warnings

175e5023: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.

This merge request adds a new rule to app/assets/stylesheets/framework/common.scss or app/assets/stylesheets/utilities.scss.

This merge request changed undocumented Vue components in vue_shared/. Please consider creating Stories for these components:

ee/app/assets/javascripts/vue_shared/showcase/card_security_showcase_app.vue
ee/app/assets/javascripts/vue_shared/showcase/card_showcase.vue

1 Message

CHANGELOG missing:

If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog.

If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message.

If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
frontend	Anna Vovchenko (`@anna_vovchenko`) (UTC+3, same timezone as `@a_akgun`)	David O'Regan (`@oregand`) (UTC+1, 2 hours behind `@a_akgun`)
UX	Sascha Eggenberger (`@seggenberger`) (UTC+2, 1 hour behind `@a_akgun`)	Jeremy Elder (`@jeldergl`) (UTC-5, 8 hours behind `@a_akgun`)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

Changes to utility SCSS files

Addition to `app/assets/stylesheets/utilities.scss`

You have added a new rule to app/assets/stylesheets/utilities.scss. Are you sure you need this rule?

If it is a component class shared across items, could it be added to the component as a utility class or to the component's stylesheet? If not, consider adding it to app/assets/stylesheets/framework/common.scss

If it is a new utility class, is there another class that shares the same values in either this file or in app/assets/stylesheets/utilities.scss? If not, please be sure this addition follows the Gitlab UI naming style so it may be removed when these rules are included. See Include gitlab-ui utility-class library for more about this project.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 84df1610 and 9b719238

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
mainChunk	1.98 MB	1.96 MB	-11.95 KB	-0.6 %
average	3.54 MB	3.53 MB	-9.25 KB	-0.3 %

Significant Growth: 17

Expand

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
pages.projects.work_items	974.28 KB	1.35 MB	+403.52 KB	41.4 %
pages.projects.merge_requests.show	5.38 MB	5.52 MB	+142.08 KB	2.6 %
pages.projects.releases.edit	1.56 MB	1.61 MB	+55.13 KB	3.5 %
pages.projects.releases.new	1.56 MB	1.61 MB	+55.13 KB	3.5 %
pages.admin.audit_logs	1.22 MB	1.25 MB	+31.4 KB	2.5 %
pages.groups.audit_events	1.22 MB	1.25 MB	+29.56 KB	2.4 %
pages.projects.audit_events	1.39 MB	1.42 MB	+29.56 KB	2.1 %
pages.operations.environments	339.03 KB	351.27 KB	+12.24 KB	3.6 %
pages.operations.index	467.45 KB	479.69 KB	+12.24 KB	2.6 %
pages.admin	18.64 KB	20.48 KB	+1.84 KB	9.9 %

The table above is limited to 10 entries. Please look at the full report for more details

New entry points: 2

Expand

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
pages.groups.runners.index	0 Bytes	1.39 MB	+1.39 MB	100.0 %
pages.groups.runners.show	0 Bytes	1013.91 KB	+1013.91 KB	100.0 %

Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.

Please consider pinging someone from the FE Foundations (@dmishunov, @justin_ho, @mikegreiling or @nmezzopera) for review, if you are unsure about the size increase.

Note: We do not have exact data for 84df1610. So we have used data from: a387ecca.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun the bundle-size-review job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

Please look at the full report for more details

Allure report

allure-report-publisher generated test report!

review-qa-blocking: test report for 9b719238

expand test summary

+---------------------------------------------------------------------------+
|                              suites summary                               |
+----------------------+--------+--------+---------+-------+-------+--------+
|                      | passed | failed | skipped | flaky | total | result |
+----------------------+--------+--------+---------+-------+-------+--------+
| Create               | 23     | 0      | 2       | 23    | 25    | ❗     |
| Verify               | 12     | 0      | 1       | 12    | 13    | ❗     |
| Plan                 | 47     | 0      | 1       | 47    | 48    | ❗     |
| Manage               | 37     | 0      | 2       | 39    | 39    | ❗     |
| Secure               | 2      | 0      | 0       | 2     | 2     | ❗     |
| Package              | 0      | 0      | 1       | 0     | 1     | ➖     |
| Version sanity check | 0      | 0      | 1       | 0     | 1     | ➖     |
| Protect              | 2      | 0      | 0       | 2     | 2     | ❗     |
| Configure            | 0      | 0      | 1       | 0     | 1     | ➖     |
+----------------------+--------+--------+---------+-------+-------+--------+
| Total                | 123    | 0      | 9       | 125   | 132   | ❗     |
+----------------------+--------+--------+---------+-------+-------+--------+

resolved all threads

added 1 commit

7281d047 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 1 commit

6e2c9366 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 1 commit

7376f7a0 - Improve box sizing

Compare with previous version

added 1 commit

455e5738 - Security showcase card sizing

Compare with previous version

added UX label

Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.