Rewrite rugged ref updates to use gitaly RPCs
What does this MR do and why?
Soon we will begin to use the praefect database in tests and when this happens we can no longer rely on being able to directly manipulate repositories without praefect knowing.
Ref updates are low hanging fruit that can easily be migrated to RPCs in bulk.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.2
added groupgitaly typemaintenance labels
assigned to @proglottis
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @stanhu
,@rymai
,@tkuah
,@rspeicher
,@marin
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Kassio Borges ( @kassio
) (UTC+1, 11 hours behind@proglottis
)Dylan Griffith ( @DylanGriffith
) (UTC+10, 2 hours behind@proglottis
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Sincheol (David) Kim
@nicolasdular mind taking the initial review?
Thanks!
requested review from @nicolasdular
requested review from @dskim_gitlab and removed review request for @nicolasdular
@nicolasdular
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
mentioned in merge request !91327 (merged)
mentioned in merge request !90315 (merged)
Setting label(s) Category:Gitaly devopssystems sectionenablement based on groupgitaly.
added Category:Gitaly devopssystems sectioncore platform labels
enabled an automatic merge when the pipeline for 336543e1 succeeds
- A deleted user
added backend label
mentioned in commit 50c3b4c9
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label