Modifies Package Registry group settings
What does this MR do and why?
Make changes to Package Registry group settings
- Changes title & description
- Removes flex-box for Exceptions toggle
This MR is part of series of MRs related to #363424 (closed)
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Visit 'Group' > 'Settings' > 'Packages & Registries'
- Confirm 'Package Registry' section has new title, changed description & layout for 'Exceptions' is changed
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.2
assigned to @rchanila
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @dbalexandre
,@mayra-cabrera
,@marin
,@dzaporozhets
,@seanarnold
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Bot1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Diana Zubova ( @dzubova
) (UTC+2, 8 hours behind@rchanila
)Illya Klymov ( @xanf
) (UTC+3, 7 hours behind@rchanila
)test for spec/features/*
Sofia Vistas ( @svistas
) (UTC+1, 9 hours behind@rchanila
)Maintainer review is optional for test for spec/features/*
UX Nick Leonard ( @nickleonard
) (UTC-5, 15 hours behind@rchanila
)Pedro Moreira da Silva ( @pedroms
) (UTC+1, 9 hours behind@rchanila
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Dangerrequested review from @aturinske and @seggenberger
- Resolved by Peter Hegman
Hey @aturinske & @seggenberger would you be able to do frontend & UX review?
Please let me know if you are busy. Thanks!
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 6bf34ac6 and 11da5b02
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.54 MB 3.54 MB - 0.0 % mainChunk 1.98 MB 1.98 MB - 0.0 %
Note: We do not have exact data for 6bf34ac6. So we have used data from: 2e888a8a.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 1 commit
- 6b2f34a8 - Update spec/features for packages & registries
Allure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for 11da5b02expand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Verify | 12 | 0 | 1 | 2 | 13 | ❗ | | Plan | 48 | 0 | 1 | 3 | 49 | ❗ | | Manage | 37 | 0 | 2 | 2 | 39 | ❗ | | Create | 23 | 0 | 2 | 7 | 25 | ❗ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 126 | 0 | 9 | 16 | 135 | ❗ | +----------------------+--------+--------+---------+-------+-------+--------+
package-and-qa:
test report for aa7a9d0fexpand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Verify | 240 | 0 | 18 | 0 | 258 | ✅ | | Manage | 619 | 3 | 24 | 0 | 646 | ❌ | | Create | 922 | 0 | 37 | 0 | 959 | ✅ | | Product Intelligence | 13 | 0 | 0 | 0 | 13 | ✅ | | Secure | 126 | 0 | 12 | 0 | 138 | ✅ | | Package | 149 | 0 | 33 | 0 | 182 | ✅ | | Plan | 326 | 0 | 6 | 0 | 332 | ✅ | | Release | 36 | 0 | 0 | 0 | 36 | ✅ | | Configure | 1 | 0 | 18 | 0 | 19 | ✅ | | Protect | 12 | 0 | 0 | 0 | 12 | ✅ | | Fulfillment | 13 | 0 | 66 | 0 | 79 | ✅ | | Enablement:Search | 9 | 0 | 1 | 0 | 10 | ✅ | | Version sanity check | 0 | 0 | 6 | 0 | 6 | ➖ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 2466 | 3 | 221 | 0 | 2690 | ❌ | +----------------------+--------+--------+---------+-------+-------+--------+
requested review from @svistas
- Resolved by Peter Hegman
- Resolved by Rahul Chanila
LGTM! One small suggestion, but I can pre-approve.
removed review request for @aturinske
@aturinske
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
- The
gitlab-qa-mirror
downstream pipeline for !90381 (873096b1) failed! - The
gitlab-qa-mirror
downstream pipeline for !90381 (aa7a9d0f) failed! - The
gitlab-qa-mirror
downstream pipeline for !90381 (aa7a9d0f) passed.
- The
requested review from @peterhegman
@rchanila LGTM!
Also FYI we do similar changes here: !90239 (merged) so this change is perfectly in sync!
Edited by Sascha Eggenbergerremoved review request for @peterhegman
mentioned in issue #363424 (closed)
removed review request for @svistas
enabled an automatic merge when the pipeline for c7fe130a succeeds
requested review from @peterhegman
added 1125 commits
-
aa7a9d0f...6bf34ac6 - 1119 commits from branch
master
- 47c68a39 - Modifies Package Registry group settings
- e93d0b7b - Update spec/features for packages & registries
- a9e11bcb - Fix user searches in settings feature spec
- f66bac48 - Update wrong assertion in feature spec
- fb6eff06 - Remove unnecessary GlSprintf
- 11da5b02 - Add back span with data-testid
Toggle commit list-
aa7a9d0f...6bf34ac6 - 1119 commits from branch
enabled an automatic merge when the pipeline for 40547643 succeeds
mentioned in commit b7fa94af
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in epic &8134 (closed)
mentioned in issue #367659 (closed)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1252 (merged)
mentioned in issue #363428 (closed)