Clean up merge_request_pipelines_in_target_project feature flag
What does this MR do and why?
This MR cleans up a very old feature flag ci_disallow_to_create_merge_request_pipelines_in_target_project
, that has been forgotten for a long time.
This flag was added for selectively disabling by actor just in case (the feature itself has already been globally enabled for a while), however, it never been used for that purpose.
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @shinya.maeda
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @tigerwnz
,@rspeicher
,@brodock
,@igor.drozdov
,@drew
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Bot1 Warning This merge request does not refer to an existing milestone. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Kassio Borges ( @kassio
) (UTC+1, 8 hours behind@shinya.maeda
)Douglas Barbosa Alexandre ( @dbalexandre
) (UTC-3, 12 hours behind@shinya.maeda
)test for spec/features/*
Kassio Borges ( @kassio
) (UTC+1, 8 hours behind@shinya.maeda
)Maintainer review is optional for test for spec/features/*
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by 🤖 GitLab Bot 🤖
@shinya.maeda - please add typebug typefeature, typemaintenance or a subtype label to this merge request.- typebug: Defects in shipped code and fixes for those defects. This includes all the bug types (availability, performance, security vulnerability, mobile, etc.)
- typefeature: Effort to deliver new features, feature changes & improvements. This includes all changes as part of new product requirements like application limits.
- typemaintenance: Up-keeping efforts & catch-up corrective improvements that are not Features nor Bugs. This includes restructuring for long-term maintainability, stability, reducing technical debt, improving the contributor experience, or upgrading dependencies.
See the handbook for more guidance on classifying.
This message was created with automation and Engineering Productivity is looking for feedback in this issue:
https://gitlab.com/gitlab-org/quality/engineering-productivity/team/-/issues/43
Allure report
allure-report-publisher
generated test report!package-and-qa-ff-deleted:
test report for 6dec55d5expand test summary
+--------------------------------------------------------------+ | suites summary | +---------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +---------+--------+--------+---------+-------+-------+--------+ | Release | 6 | 0 | 0 | 0 | 6 | ✅ | +---------+--------+--------+---------+-------+-------+--------+ | Total | 6 | 0 | 0 | 0 | 6 | ✅ | +---------+--------+--------+---------+-------+-------+--------+
- The
gitlab-qa-mirror
downstream pipeline for !90225 (9c14f42c) failed! - The
gitlab-qa-mirror
downstream pipeline for !90225 (6dec55d5) passed. - The
gitlab-qa-mirror
downstream pipeline for !90225 (6dec55d5) failed! - The
gitlab-qa-mirror
downstream pipeline for !90225 (6dec55d5) passed. - The
gitlab-qa-mirror
downstream pipeline for !90225 (6dec55d5) passed.
- The
added typemaintenance label
added 476 commits
-
9c14f42c...0345b2f9 - 475 commits from branch
master
- f23a3a10 - Clean up merge_request_pipelines_in_target_project feature flag
-
9c14f42c...0345b2f9 - 475 commits from branch
added 1 commit
- 6dec55d5 - Clean up merge_request_pipelines_in_target_project feature flag
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Kerri Miller
@tvellishetty Would you mind reviewing as backend reviewer? Thanks!
requested review from @tvellishetty
requested review from @kerrizor and removed review request for @tvellishetty
@tvellishetty
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
added grouprelease [DEPRECATED] label
Setting label(s) ~"devops::release" sectionops based on ~"group::release".
added devopsrelease [DEPRECATED] sectionops labels
enabled an automatic merge when the pipeline for 3cf3dcc5 succeeds
- A deleted user
added backend label
- A deleted user
added backend label
mentioned in commit f4ba3fc6
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1252 (merged)
changed milestone to %15.2