Migrate button to delete account
What does this MR do and why?
Migrates the button to delete account to ViewComponent.
Before | After |
---|---|
![]() |
![]() |
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #364015 (closed)
Merge request reports
Activity
changed milestone to %15.1
added OKR-FY24Q2 component:button frontend grouppersonal productivity pajamasintegrate sectiondev severity4 typemaintenance + 1 deleted label
assigned to @mvanremmerden
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @rspeicher
,@marin
,@nick.thomas
,@godfat
,@jameslopez
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Bot1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend George Koltsov ( @georgekoltsov
) (UTC+1)Dylan Griffith ( @DylanGriffith
) (UTC+10)frontend André Luís ( @andr3
) (UTC+1)Natalia Tepluhina ( @ntepluhina
) (UTC+2)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Danger- Resolved by Miguel Rincon
@minahilnichols @rzwambag On to you for a first review.
requested review from @minahilnichols and @rzwambag
Allure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for baae8350expand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Manage | 35 | 0 | 2 | 37 | 37 | ❗ | | Verify | 12 | 0 | 1 | 12 | 13 | ❗ | | Create | 23 | 0 | 2 | 23 | 25 | ❗ | | Plan | 48 | 0 | 1 | 48 | 49 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Secure | 2 | 0 | 0 | 2 | 2 | ❗ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 122 | 0 | 9 | 124 | 131 | ❗ | +----------------------+--------+--------+---------+-------+-------+--------+
@rzwambag
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
requested review from @alexpooley and removed review request for @rzwambag
added Pajamas Migration Day label
added FY23Q2 label
removed review request for @minahilnichols
requested review from @mrincon