Add VariableType and variables fields
What does this MR do and why?
- Adds
Ci::VariableType
which represents the many types of variables that exist in Gitlab CI - Adds
ci_variables
field toProjectType
,GroupType
, andQueryType
- Includes a
raw
field inVariableType
so we can now surface whether a variable is non-expanded
How to set up and validate locally
Use the following query in GraphQL to check each of the new variable fields:
{
ciVariables {
nodes {
id
key
value
variableType
raw
masked
protected
}
}
group(fullPath: "gitlab-org") {
ciVariables {
nodes {
id
key
value
variableType
raw
masked
protected
}
}
}
project(fullPath: "gitlab-org/gitlab-test") {
ciVariables {
nodes {
id
key
value
variableType
raw
masked
protected
}
}
}
}
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #361934 (closed)
Merge request reports
Activity
changed milestone to %15.1
added auto updated backend candidate15.1 devopsverify documentation grouppipeline authoring sectionops typefeature workflowin dev + 1 deleted label
assigned to @avielle
removed candidate15.1 label
removed workflowin dev label
removed auto updated label
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @rspeicher
,@marcel.amirault
,@aqualls
,@mayra-cabrera
,@engwan
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Botmentioned in issue #361934 (closed)
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
doc/api/graphql/reference/index.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Gregory Havenga ( @ghavenga
) (UTC+2, same timezone as@avielle
)Tetiana Chupryna ( @brytannia
) (UTC+2, same timezone as@avielle
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Dangeradded 2 commits
- Resolved by Avielle Wolfe
@drew could you please do the first backend review?
@marcel.amirault could you please check the GraphQL docs changes?
cc @f_caplette @mgandres this MR sets up the backend GraphQL to provide lists of project, group, and instance CI variables
requested review from @drew and @marcel.amirault
added Technical Writing label
added docsfeature label
- Resolved by Avielle Wolfe
- Resolved by Avielle Wolfe
- Resolved by Avielle Wolfe
removed review request for @marcel.amirault
@marcel.amirault
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
changed milestone to %15.2
added missed:15.1 label
Hey @avielle, sorry for the delay! This looks great. Thanks for writing very clear specs files for these, they help a lot in reviewing expected and actual behavior.
- Resolved by Furkan Ayhan
@mikolaj_wawrzyniak Would you mind doing maintainer review here? Thanks!
requested review from @mikolaj_wawrzyniak and removed review request for @drew
- Resolved by Avielle Wolfe
Hey @gitlab-com/gl-security/appsec experts can I kindly ask you to review this MR, it adds new GraphQL type that is going to expose CI/CD variables for authorized users. Since CI/CD variables often contains very sensitive data I would like to have more eyes on this change to make sure nothing problematic slips through, many thanks.
added security label
- Resolved by Furkan Ayhan
- Resolved by Furkan Ayhan
- Resolved by Furkan Ayhan
requested review from @furkanayhan
- Resolved by Dominic Couture
- Resolved by Avielle Wolfe
removed review request for @mikolaj_wawrzyniak
- Resolved by Furkan Ayhan
- Resolved by Furkan Ayhan
- Resolved by Furkan Ayhan
@avielle Looks great! I have some comments. Could you please rebase your branch? (I guess it's okay if you also squash the commits now)
removed review request for @furkanayhan
added 3086 commits
-
1ce1e2b2...03e41590 - 3084 commits from branch
master
- ece2c519 - Add VariableType and variables fields
- 3c4c8264 - Don't mask masked variables
-
1ce1e2b2...03e41590 - 3084 commits from branch
requested review from @furkanayhan
enabled an automatic merge when the pipeline for 23e13249 succeeds
mentioned in commit 4d970046
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
36 36 pipeline_analytics squash_read_only sast_ci_configuration 37 37 cluster_agent cluster_agents agent_configurations 38 38 ci_template timelogs merge_commit_template squash_commit_template work_item_types 39 recent_issue_boards ci_config_path_or_default packages_cleanup_policy 39 recent_issue_boards ci_config_path_or_default packages_cleanup_policy ci_variables 40 recent_issue_boards ci_config_path_or_default ci_variables - Comment on lines +39 to +40
Hi @avielle
Just a small questionI'm having a merge conflict at this line and noticed that some fields are duplicated and one is removed. Is it ok if I change this as follows in my MR?
@zillemarco yes, that makes sense! Please link me your MR if you'd like me to take a look
Thanks @avielle, I'll move on with the changes then (I already made them while waiting as I supposed they were ok
)If you want to take a look, the MR is !88462 (merged)
A pair of fresh eyes won't hurt since all the namespaces madness that originated from that
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in merge request !88462 (merged)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1252 (merged)
mentioned in merge request !102212 (merged)
added Category:Pipeline Composition label