Skip to content
Snippets Groups Projects

Add VariableType and variables fields

Merged Avielle Wolfe requested to merge 361934-aw-add-variable-type into master
1 unresolved thread

What does this MR do and why?

  • Adds Ci::VariableType which represents the many types of variables that exist in Gitlab CI
  • Adds ci_variables field to ProjectType, GroupType, and QueryType
  • Includes a raw field in VariableType so we can now surface whether a variable is non-expanded

How to set up and validate locally

Use the following query in GraphQL to check each of the new variable fields:

{
  ciVariables {
    nodes {
      id
      key
      value
      variableType
      raw
      masked
      protected
    }
  }
  group(fullPath: "gitlab-org") {
    ciVariables {
      nodes {
        id
        key
        value
        variableType
        raw
        masked
        protected
      }
    }
  }
  project(fullPath: "gitlab-org/gitlab-test") {
   	ciVariables {
      nodes {
        id
        key
        value
        variableType
        raw
        masked
        protected
      }
    }
  }
}

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #361934 (closed)

Edited by Avielle Wolfe

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Marcel Amirault approved this merge request

    approved this merge request

  • Marcel Amirault removed review request for @marcel.amirault

    removed review request for @marcel.amirault

  • :wave: @marcel.amirault, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • Avielle Wolfe added 1 commit

    added 1 commit

    • 645356ed - Keep to the CI/CD naming standard

    Compare with previous version

  • Avielle Wolfe added 1 commit

    added 1 commit

    Compare with previous version

  • Marcel Amirault resolved all threads

    resolved all threads

  • Avielle Wolfe marked this merge request as ready

    marked this merge request as ready

  • 🤖 GitLab Bot 🤖 changed milestone to %15.2

    changed milestone to %15.2

  • drew stachon approved this merge request

    approved this merge request

  • Hey @avielle, sorry for the delay! This looks great. Thanks for writing very clear specs files for these, they help a lot in reviewing expected and actual behavior.

  • drew stachon requested review from @mikolaj_wawrzyniak and removed review request for @drew

    requested review from @mikolaj_wawrzyniak and removed review request for @drew

  • Furkan Ayhan
  • Furkan Ayhan
  • Furkan Ayhan requested review from @furkanayhan

    requested review from @furkanayhan

  • Dominic Couture
  • Avielle Wolfe removed review request for @mikolaj_wawrzyniak

    removed review request for @mikolaj_wawrzyniak

  • Avielle Wolfe added 1 commit

    added 1 commit

    Compare with previous version

  • Furkan Ayhan
  • Furkan Ayhan
  • Furkan Ayhan removed review request for @furkanayhan

    removed review request for @furkanayhan

  • Avielle Wolfe added 3086 commits

    added 3086 commits

    Compare with previous version

  • Avielle Wolfe requested review from @furkanayhan

    requested review from @furkanayhan

  • Furkan Ayhan approved this merge request

    approved this merge request

  • Furkan Ayhan resolved all threads

    resolved all threads

  • Furkan Ayhan enabled an automatic merge when the pipeline for 23e13249 succeeds

    enabled an automatic merge when the pipeline for 23e13249 succeeds

  • merged

  • Furkan Ayhan mentioned in commit 4d970046

    mentioned in commit 4d970046

  • added workflowstaging label and removed workflowcanary label

  • 36 36 pipeline_analytics squash_read_only sast_ci_configuration
    37 37 cluster_agent cluster_agents agent_configurations
    38 38 ci_template timelogs merge_commit_template squash_commit_template work_item_types
    39 recent_issue_boards ci_config_path_or_default packages_cleanup_policy
    39 recent_issue_boards ci_config_path_or_default packages_cleanup_policy ci_variables
    40 recent_issue_boards ci_config_path_or_default ci_variables
    • Comment on lines +39 to +40

      Hi @avielle :wave: :slight_smile: Just a small question :slight_smile:

      I'm having a merge conflict at this line and noticed that some fields are duplicated and one is removed. Is it ok if I change this as follows in my MR? :slight_smile:

      Suggested change
      39 recent_issue_boards ci_config_path_or_default packages_cleanup_policy ci_variables
      40 recent_issue_boards ci_config_path_or_default ci_variables
      39 recent_issue_boards ci_config_path_or_default packages_cleanup_policy ci_variables
    • Author Maintainer

      @zillemarco yes, that makes sense! Please link me your MR if you'd like me to take a look

    • Thanks @avielle, I'll move on with the changes then (I already made them while waiting as I supposed they were ok :sweat_smile:) :slight_smile:

      If you want to take a look, the MR is !88462 (merged) :slight_smile: A pair of fresh eyes won't hurt since all the namespaces madness that originated from that :sweat_smile:

    • Please register or sign in to reply
  • Marco Zille mentioned in merge request !88462 (merged)

    mentioned in merge request !88462 (merged)

  • Avielle Wolfe mentioned in merge request !102212 (merged)

    mentioned in merge request !102212 (merged)

  • Please register or sign in to reply
    Loading