Skip to content

Fix Advanced Search Opensearch detection

Dmitry Gruzd requested to merge 363714-fix-search-check into master

What does this MR do and why?

This MR fixes the logic we use in SystemCheck::App::SearchCheck and refactors it to use Gitlab::Elastic::Helper.default.server_info instead of duplicating the logic for detecting ES distribution and version.

The problem is that SystemCheck::App::SearchCheck returns incorrect distribution for Opensearch:

SystemCheck::App::SearchCheck.current_version
=> #<Gitlab::VersionInfo:0x00007fe224d0cec0 @major=1, @minor=2, @patch=4>

SystemCheck::App::SearchCheck.distribution
=> "elasticsearch"

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #363714 (closed)

Edited by Dmitry Gruzd

Merge request reports

Loading