Add skeleton loader for usage_quota's storage
-
Review changes -
-
Download -
Patches
-
Plain diff
Merged
Ammar Alakkad requested to merge 356659-add-skeleton-loader-to-usage-quotas-storage into master
What does this MR do and why?
- Adds a skeleton loader to statistics-card giving more useful feedback to users, and update namespace storage app to utilize it
- Refactor
storage_usage_statistics_spec.js
to usecreateMockApollo
Screenshots or screen recordings
loading | loaded | with error |
---|---|---|
![]() |
![]() |
![]() |
How to set up and validate locally
- Navigate to a group's usage quota > storage
- Observe the loader after the page loads
- (alternatively from Vue DevTools locate
<storage-usage-statistics>
and manually update itsloading
prop) - To test the error alert you can mess the
ee/app/assets/javascripts/usage_quotas/storage/queries/namespace_storage.query.graphql
query to throw an error (like rename$fullPath
to some gibberish )
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #356659 (closed)
Edited by Ammar Alakkad
Merge request reports
Compare and
Show latest version
- version 300c720d98
- version 2916228395
- version 28c90789df
- version 273d9b020f
- version 26a944cbe9
- version 259389690f
- version 240e3408ab
- version 23007ac822
- version 22310a2ab6
- version 21919cbcad
- version 2076e9f856
- version 193a5f2e81
- version 181fded9e0
- version 1713f7f1ab
- version 161b413e90
- version 155bfe96cf
- version 14d0f5952b
- version 139f9a3f22
- version 1276f66936
- version 11d931c958
- version 10ecb53a4a
- version 9f4b4b4e4
- version 819550fc9
- version 720b5cf8e
- version 6f6c3cca4
- version 54dfb5eaa
- version 476cccc73
- version 368aa4262
- version 2ad642f86
- version 12f68f643
- master (base)
- latest versionb4629ae06 commits,
- version 300c720d986 commits,
- version 29162283956 commits,
- version 28c90789df5 commits,
- version 273d9b020f4 commits,
- version 26a944cbe94 commits,
- version 259389690f4 commits,
- version 240e3408ab3 commits,
- version 23007ac8223 commits,
- version 22310a2ab61 commit,
- version 21919cbcad9 commits,
- version 2076e9f8568 commits,
- version 193a5f2e817 commits,
- version 181fded9e07 commits,
- version 1713f7f1ab7 commits,
- version 161b413e906 commits,
- version 155bfe96cf5 commits,
- version 14d0f5952b5 commits,
- version 139f9a3f224 commits,
- version 1276f669364 commits,
- version 11d931c9584 commits,
- version 10ecb53a4a3 commits,
- version 9f4b4b4e43 commits,
- version 819550fc93 commits,
- version 720b5cf8e3 commits,
- version 6f6c3cca42 commits,
- version 54dfb5eaa3 commits,
- version 476cccc732 commits,
- version 368aa42622 commits,
- version 2ad642f862 commits,
- version 12f68f6431 commit,
Compare changes
- Side-by-side
- Inline
Files
563Loading