Resolve "GitLab Migration - migrations with status timeout (3) are not updated in the UI"
What does this MR do and why?
This MR adds handling of timeout
status for Gitlab Migration
Related to #358153 (closed)
Screenshots or screen recordings
How to set up and validate locally
- Open "New group" -> Import (
/groups/new
) - Use
https://gitlab.com
as source instance andGeK1Nis4j-SY1X4sqE5c
as personal access token (this token is from separate user on GitLab instance with 0 real data available, so we do not expose any security risks here) - Initiate new import and wait it to become "complete"
- Open
bundle exec rails console
- Run
m = BulkImport.last
m.status = 3
m.save
(3 is timeout
)
- Refresh page, observe
timeout
status
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.0
assigned to @xanf
Suggested Reviewers (beta)
This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".
The individuals below may be good candidates to participate in the review based on various factors.
After you review all recommendations, please assign reviewers manually, as this is not done automatically.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Reviewers @iamphill
,@jerasmus
,@ntepluhina
,@xanf
,@ekigbo
If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot
- A deleted user
added featureaddition typefeature labels
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Nicolas Dular ( @nicolasdular
) (UTC+2, 1 hour behind@xanf
)Phil Hughes ( @iamphill
) (UTC+1, 2 hours behind@xanf
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 4bd23f6b and 87ac532f
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent mainChunk 1.93 MB 1.93 MB -4.13 KB -0.2 % average 3.45 MB 3.45 MB +1.31 KB 0.0 % Significant Growth: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.threat_monitoring.show 1.66 MB 1.75 MB +89.49 KB 5.3 % New entry points: 3Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.serverless 0 Bytes 4.51 MB +4.51 MB 100.0 % pages.projects.wikis.edit 0 Bytes 1.36 MB +1.36 MB 100.0 % pages.groups.wikis.edit 0 Bytes 1.26 MB +1.26 MB 100.0 % Significant Reduction: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.quality.test_cases.new 1.69 MB 1.65 MB -40.63 KB -2.3 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@dmishunov
,@justin_ho
,@mikegreiling
or@nmezzopera
) for review, if you are unsure about the size increase.Note: We do not have exact data for 4bd23f6b. So we have used data from: 990f51c1.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Olena Horal-Koretska
@thomasrandolph could you please review this one?
added 1 deleted label and removed featureaddition label
requested review from @thomasrandolph
Allure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for 87ac532fexpand test summary
+-------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+--------+ | | passed | failed | skipped | flaky | result | +----------------------+--------+--------+---------+-------+--------+ | Verify | 12 | 0 | 1 | 8 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | ➖ | | Create | 24 | 0 | 2 | 12 | ❗ | | Manage | 31 | 0 | 2 | 22 | ❗ | | Plan | 41 | 0 | 1 | 8 | ❗ | | Package | 0 | 0 | 1 | 0 | ➖ | | Configure | 0 | 0 | 1 | 0 | ➖ | | Protect | 2 | 0 | 0 | 0 | ✅ | +----------------------+--------+--------+---------+-------+--------+ | Total | 110 | 0 | 9 | 50 | ❗ | +----------------------+--------+--------+---------+-------+--------+
requested review from @ohoral and removed review request for @thomasrandolph
@thomasrandolph
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
- Resolved by Olena Horal-Koretska
enabled an automatic merge when the pipeline for 24dbfc4a succeeds
mentioned in commit 290f9fe5
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1040 (merged)
added releasedpublished label and removed releasedcandidate label
added groupimport and integrate label and removed 1 deleted label