Fix hostname check when fetching ip address

What does this MR do and why?

Describe in detail what your merge request does and why.

Fixes failure in ee/browser_ui/1_manage/group/restrict_by_ip_address_spec.rb when running against review app when a branch has test in its name resulting in the review app url to contain test such as in this case: https://gitlab.com/gitlab-org/gitlab/-/jobs/2359906629

The test fails at this line, where we check if the url has test in it and here it matches the review app url (e.g. https://gitlab-review-mk-test-th-pv2gqw.gitlab-review.app) and the condition falls to the else block and returns the internal address of the container running the test instead of the public ip address.

This MR changes the text to match in the host to .test.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

changed milestone to %15.0

added QA Quality devopsfoundations groupauthentication and authorization [DEPRECATED] priority3 severity3 typebug labels

assigned to @sliaquat

mentioned in merge request !84564 (closed)

Suggested Reviewers (beta)

This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".

The individuals below may be good candidates to participate in the review based on various factors.

After you review all recommendations, please assign reviewers manually, as this is not done automatically.

You can use slash commands in comments to quickly assign /assign_reviewer @user1.

Reviewers
@tomi, @ddavison, @a_mcdonald, @sliaquat, @mlapierre

If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

Automatically generated by Suggested Reviewers Bot

	1 Message
	CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog. If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message. If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

If needed, you can retry the danger-review job that generated this comment.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
QA	Vincy Wilson (@vincywilson) (UTC-4, 9 hours behind @sliaquat)	Andrejs Cunskis (@acunskis) (UTC+3, 2 hours behind @sliaquat)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

Generated by Danger

Allure report

allure-report-publisher generated test report!

review-qa-blocking: test report for dea0ee1a

expand test summary

+-------------------------------------------------------------------+
|                          suites summary                           |
+----------------------+--------+--------+---------+-------+--------+
|                      | passed | failed | skipped | flaky | result |
+----------------------+--------+--------+---------+-------+--------+
| Create               | 17     | 0      | 2       | 3     | ❗     |
| Manage               | 26     | 0      | 2       | 12    | ❗     |
| Package              | 24     | 0      | 1       | 23    | ❗     |
| Plan                 | 41     | 0      | 1       | 1     | ❗     |
| Verify               | 12     | 0      | 1       | 7     | ❗     |
| Version sanity check | 0      | 0      | 1       | 0     | ➖     |
| Protect              | 2      | 0      | 0       | 0     | ✅     |
| Configure            | 0      | 0      | 1       | 0     | ➖     |
+----------------------+--------+--------+---------+-------+--------+
| Total                | 122    | 0      | 9       | 46    | ❗     |
+----------------------+--------+--------+---------+-------+--------+

review-qa-all: test report for dea0ee1a

expand test summary

+----------------------------------------------------------+
|                      suites summary                      |
+-------------+--------+--------+---------+-------+--------+
|             | passed | failed | skipped | flaky | result |
+-------------+--------+--------+---------+-------+--------+
| Verify      | 25     | 0      | 2       | 20    | ❗     |
| Plan        | 11     | 0      | 0       | 6     | ❗     |
| Create      | 127    | 0      | 5       | 91    | ❗     |
| Manage      | 56     | 1      | 7       | 40    | ❌     |
| Secure      | 17     | 0      | 2       | 17    | ❗     |
| Fulfillment | 0      | 1      | 11      | 1     | ❌     |
| Non-devops  | 1      | 0      | 1       | 1     | ❗     |
| Release     | 6      | 0      | 0       | 4     | ❗     |
| Package     | 0      | 0      | 2       | 0     | ➖     |
| Configure   | 0      | 0      | 2       | 0     | ➖     |
+-------------+--------+--------+---------+-------+--------+
| Total       | 243    | 2      | 32      | 180   | ❌     |
+-------------+--------+--------+---------+-------+--------+

package-and-qa: test report for dea0ee1a

expand test summary

+-------------------------------------------------------------------+
|                          suites summary                           |
+----------------------+--------+--------+---------+-------+--------+
|                      | passed | failed | skipped | flaky | result |
+----------------------+--------+--------+---------+-------+--------+
| Manage               | 334    | 0      | 20      | 7     | ❗     |
| Create               | 464    | 0      | 25      | 23    | ❗     |
| Verify               | 124    | 0      | 8       | 5     | ❗     |
| Plan                 | 182    | 0      | 1       | 0     | ✅     |
| Non-devops           | 8      | 0      | 0       | 3     | ❗     |
| Package              | 159    | 2      | 12      | 16    | ❌     |
| Configure            | 1      | 0      | 12      | 0     | ✅     |
| Fulfillment          | 9      | 0      | 36      | 0     | ✅     |
| Secure               | 54     | 0      | 5       | 2     | ❗     |
| Protect              | 6      | 0      | 0       | 0     | ✅     |
| Release              | 19     | 0      | 0       | 0     | ✅     |
| Version sanity check | 0      | 0      | 3       | 0     | ➖     |
+----------------------+--------+--------+---------+-------+--------+
| Total                | 1360   | 2      | 122     | 56    | ❌     |
+----------------------+--------+--------+---------+-------+--------+

@vincywilson Could you review this minor fix please? Thanks.

requested review from @vincywilson

approved this merge request

• The gitlab-qa-mirror downstream pipeline for !86126 (dea0ee1a) failed!

mentioned in issue #350478 (closed)

resolved all threads

merged

@sliaquat, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline finished more than 2 hours ago, you should:

1. Ensure the merge request is not in Draft status.
2. Start a pipeline (especially important for Community contribution merge requests).
3. Set the merge request to merge when pipeline succeeds.

(Improve this message?)

mentioned in commit 1ec5308d

added workflowstaging-canary label

added workflowcanary label and removed workflowstaging-canary label

added workflowstaging label and removed workflowcanary label

added workflowproduction label and removed workflowstaging label

added releasedcandidate label

added releasedpublished label and removed releasedcandidate label