Hide iteration menu for user namespaced projects
What does this MR do and why?
Resolves #354735 (closed)
Hide the left navbar submenu Iterations
for personal projects because Iterations is a group feature.
How to set up and validate locally
-
Create a personal project (a project that's namespaced to a user.)
-
Navigate to the project and compare its left navbar to that of a group-namespaced project:
Personal project | Group project |
---|---|
![]() |
![]() |
Before this MR, Iterations
incorrectly showed up in personal projects.
Merge request reports
Activity
changed milestone to %15.0
assigned to @euko
added typemaintenance label and removed typebug label
added 1 commit
- 05f29587 - Hide iteration menu from user namespaced project
Suggested Reviewers (beta)
This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".
The individuals below may be good candidates to participate in the review based on various factors.
After you review all recommendations, please assign reviewers manually, as this is not done automatically.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Reviewers @arturoherrero
,@jivanvl
,@toupeira
,@ohoral
,@psimyn
If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Shreyas Agarwal ( @shreyasagarwal
) (UTC+2, 2 hours ahead of@euko
)Mayra Cabrera ( @mayra-cabrera
) (UTC-5, 5 hours behind@euko
)test Quality for spec/features/*
Désirée Chevalier ( @dchevalier2
) (UTC-4, 4 hours behind@euko
)Maintainer review is optional for test Quality for spec/features/*
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
DangerAllure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for a21c642dexpand test summary
+-------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+--------+ | | passed | failed | skipped | flaky | result | +----------------------+--------+--------+---------+-------+--------+ | Create | 17 | 0 | 2 | 3 | ❗ | | Verify | 12 | 0 | 1 | 7 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | ➖ | | Plan | 41 | 0 | 1 | 1 | ❗ | | Manage | 28 | 0 | 2 | 14 | ❗ | | Protect | 2 | 0 | 0 | 0 | ✅ | | Package | 24 | 0 | 1 | 24 | ❗ | | Configure | 0 | 0 | 1 | 0 | ➖ | +----------------------+--------+--------+---------+-------+--------+ | Total | 124 | 0 | 9 | 49 | ❗ | +----------------------+--------+--------+---------+-------+--------+
test report for 05f29587 ```markdown +-------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+--------+ | | passed | failed | skipped | flaky | result | +----------------------+--------+--------+---------+-------+--------+ | Create | 590 | 4 | 32 | 44 | | | Package | 160 | 1 | 15 | 16 | | | Manage | 376 | 0 | 24 | 1 | | | Plan | 220 | 0 | 1 | 0 | | | Verify | 148 | 0 | 12 | 8 | | | Enablement:Search | 9 | 0 | 1 | 0 | | | Secure | 68 | 0 | 8 | 4 | | | Configure | 1 | 0 | 12 | 0 | | | Fulfillment | 9 | 0 | 40 | 0 | | | Release | 24 | 0 | 0 | 0 | | | Non-devops | 9 | 0 | 0 | 5 | | | Protect | 8 | 0 | 0 | 0 | | | Version sanity check | 0 | 0 | 4 | 0 | | +----------------------+--------+--------+---------+-------+--------+ | Total | 1622 | 5 | 149 | 78 | | +----------------------+--------+--------+---------+-------+--------+ ```- Resolved by Jan Provaznik
@tigerwnz, can you please review backend?
@dchevalier2, could you also review test please?
Edited by euko
requested review from @dchevalier2 and @tigerwnz
requested review from @jprovaznik and removed review request for @tigerwnz
@tigerwnz
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
- Resolved by Jan Provaznik
removed review request for @jprovaznik
The
package-and-qa
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/525533043 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/526151620 downstream.The
gitlab-qa
downstream pipeline failed! .Known unrelated failures #360543 (closed)
removed review request for @dchevalier2
requested review from @jprovaznik
Thanks @euko, LGTM
, MWPS setenabled an automatic merge when the pipeline for 1bbd5fc6 succeeds
mentioned in commit f173922e
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1040 (merged)
added releasedpublished label and removed releasedcandidate label