Hide security rules for non ultimate licenses
What does this MR do and why?
Hide security rules for non ultimate licenses
Follow up from MR: !84328 (merged)
Related issue: #357021 (closed)
Screenshots or screen recordings
Other than ultimate license
Ultimate license
How to set up and validate locally
- Create and assign a security orchestration policy as described here.
- Create at least one scan result policy.
- Go to project -> settings -> general -> merge request approvals.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.0
assigned to @zmartins
Suggested Reviewers (beta)
This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".
The individuals below may be good candidates to participate in the review based on various factors.
After you review all recommendations, please assign reviewers manually, as this is not done automatically.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Reviewers @svedova
,@nmezzopera
,@afontaine
,@kerrizor
,@oregand
If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot
Edited by GitLab Reviewer-Recommender BotReviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Aditya Tiwari ( @atiwari71
) (UTC+5.5, 9.5 hours ahead of@zmartins
)Patrick Bajao ( @patrickbajao
) (UTC+8, 12 hours ahead of@zmartins
)frontend Tristan Read ( @tristan.read
) (UTC+12, 16 hours ahead of@zmartins
)Natalia Tepluhina ( @ntepluhina
) (UTC+2, 6 hours ahead of@zmartins
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits fb54776b and afc40884
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.45 MB 3.45 MB +3.29 KB 0.1 % mainChunk 1.93 MB 1.93 MB - -0.0 % Significant Growth: 7Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.groups.settings.ci_cd.show 530.69 KB 1.36 MB +859.38 KB 161.9 % pages.projects.show 1.68 MB 1.89 MB +209.86 KB 12.2 % pages.projects.security.policies.index 2.59 MB 2.78 MB +196.52 KB 7.4 % pages.groups.security.policies.index 2.45 MB 2.64 MB +196.32 KB 7.8 % pages.projects.security.policies.edit 2.52 MB 2.62 MB +108.07 KB 4.2 % pages.projects.security.policies.new 2.52 MB 2.62 MB +108.07 KB 4.2 % pages.groups.security.policies.new 2.35 MB 2.46 MB +107.87 KB 4.5 % Significant Reduction: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent sandboxed_mermaid 1.08 MB 1.05 MB -30.35 KB -2.7 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@dmishunov
,@justin_ho
,@mikegreiling
or@nmezzopera
) for review, if you are unsure about the size increase.Note: We do not have exact data for fb54776b. So we have used data from: ca09cf6a.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for afc40884+-------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+--------+ | | passed | failed | skipped | flaky | result | +----------------------+--------+--------+---------+-------+--------+ | Manage | 28 | 0 | 2 | 14 | ❗ | | Plan | 41 | 0 | 1 | 1 | ❗ | | Package Registry | 6 | 0 | 0 | 6 | ❗ | | Create | 15 | 0 | 2 | 3 | ❗ | | Verify | 12 | 0 | 1 | 7 | ❗ | | SSH keys support | 2 | 0 | 0 | 0 | ✅ | | Version sanity check | 0 | 0 | 1 | 0 | ➖ | | Protect | 3 | 0 | 0 | 0 | ✅ | | Configure | 0 | 0 | 1 | 0 | ➖ | | Package | 0 | 0 | 1 | 0 | ➖ | +----------------------+--------+--------+---------+-------+--------+ | Total | 107 | 0 | 9 | 31 | ❗ | +----------------------+--------+--------+---------+-------+--------+
added 1 commit
- afc40884 - Hide security rules for non ultimate licenses
- Resolved by Jacques Erasmus
@atiwari71 Would you mind reviewing the backend ?
@tristan.read Would you mind reviewing the frontend ?
requested review from @atiwari71 and @tristan.read
removed workflowverification label
removed typefeature label
added typemaintenance label
removed review request for @atiwari71
requested review from @jerasmus
@tristan.read
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
requested review from @atiwari71
requested review from @toupeira
removed review request for @atiwari71
enabled an automatic merge when the pipeline for 87b32c2c succeeds
mentioned in commit d5ce7ff4
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1040 (merged)