Skip to content
GitLab
Next

Fix unresolved name due to cyclic definition

Merged Brett Walker requested to merge bw-graphql-cyclic-issue-connection into master

What does this MR do and why?

Normally this wouldn't be needed and we could use

type Types::IssueType.connection_type, null: true

in a resolver, such as app/graphql/resolvers/base_issues_resolver.rb. However we can end up with cyclic definitions, which can result in errors like

NameError: uninitialized constant Resolvers::GroupIssuesResolver

Now we would use

type "Types::IssueConnection", null: true

which gives a delayed resolution, and the proper connection type.

See app/graphql/resolvers/base_issues_resolver.rb

Reference: https://github.com/rmosolgo/graphql-ruby/issues/3974#issuecomment-1084444214

This is related to [graphql] Main issue/MR for converting to the n... (#210556 - closed). The failure this fixes only happens with the new gem. However fixing in master reduces the overall complexity of [graphql] Convert to using the new query interp... (&7734 - closed)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Brett Walker