Fix NoMethodError for CommitController
What does this MR do and why?
- Contributes to #351520 (closed)
- Sentry error: https://sentry.gitlab.net/gitlab/gitlabcom/issues/3214315
Problem
Verification for commit presence is missing for #revert
and #cherry-pick
methods.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %14.10
added backend groupsource code typebug labels
assigned to @vyaklushin
Setting label(s) Category:Source Code Management devopscreate sectiondev based on groupsource code.
added Category:Source Code Management devopscreate sectiondev labels
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Nicolas Dular ( @nicolasdular
) (UTC+1, same timezone as@vyaklushin
)Michael Kozono ( @mkozono
) (UTC-7, 8 hours behind@vyaklushin
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Dangeradded 851 commits
-
dbd20762...5a0af135 - 850 commits from branch
master
- c735208e - Fix NoMethodError for CommitController
-
dbd20762...5a0af135 - 850 commits from branch
Allure report
allure-report-publisher
generated test report for c735208e!review-qa-reliable:
test report
review-qa-smoke: test report- Resolved by Luke Duncalfe
Hi @nicolasdular!
Can you please review this fix?
requested review from @nicolasdular
requested review from @.luke and removed review request for @nicolasdular
@nicolasdular
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
enabled an automatic merge when the pipeline for 2de4c426 succeeds
Thanks, @vyaklushin! Set to merge when the pipeline succeeds
.mentioned in commit 7025b3f3
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!918 (merged)