Remove calls to deprecated `to_graphql`
What does this MR do and why?
.to_graphql
is deprecated to GraphQL-Ruby 2.0. While our current code base, which is user 1.11.x
of the graphql gem is not seeing this deprecation message, we're seeing it in !27536 (merged) as we're upgrading the gem.
Legacy `.to_graphql` objects are deprecated and will be removed in GraphQL-Ruby 2.0. Remove `.to_graphql` to use a class-based definition instead.
This MR removes what is possible now, to minimize changes in !27536 (merged).
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %14.9
added GraphQL groupproject management typemaintenance labels
assigned to @digitalmoksha
mentioned in merge request !75373 (merged)
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
If needed, you can retry the
danger-review
job that generated this comment.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Diogo Frazão ( @dfrazao-gitlab
) (UTC+0, 5 hours ahead of@digitalmoksha
)Pavel Shutsin ( @pshutsin
) (UTC+1, 6 hours ahead of@digitalmoksha
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Dangeradded 1 commit
- d3ec9d4f - Method to_graphql is deprecated, begin removing
added 1 commit
- ca8dfebc - Method to_graphql is deprecated, begin removing
Setting label(s) devopsplan sectiondev based on groupproject management.
added devopsplan sectiondev labels
added 1 commit
- 4e59cbf9 - Method to_graphql is deprecated, begin removing
- Resolved by Pavel Shutsin
@allison.browne would mind doing the first review on this?
requested review from @allison.browne
@allison.browne
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
requested review from @pshutsin
added 410 commits
-
4e59cbf9...fd2ad8c8 - 409 commits from branch
master
- 33d33c5a - Method to_graphql is deprecated, begin removing
-
4e59cbf9...fd2ad8c8 - 409 commits from branch
removed review request for @allison.browne
removed review request for @pshutsin
enabled an automatic merge when the pipeline for c0d44bf7 succeeds
mentioned in commit 43651bd7
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label