Request deployment target info from users on new projects
What does this MR do and why?
This MR adds a select to the project creation form to request deployment target info from our users.
The selected option is tracked via Snowplow when the form is submitted. The event has following structure:
'select_deployment_target', {
label: 'new_project_deployment_target',
property: <selectedTarget>,
});
Screenshots or screen recordings
How to set up and validate locally
- Follow this guide to enable snowplow events locally
- Go to the Create new project -> Create blank project
- Validate the event being sent if the deployment target was selected and the form was submitted.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #347547 (closed)
Merge request reports
Activity
changed milestone to %14.8
assigned to @anna_vovchenko
removed auto updated label
removed tooling (archive) label
added featureaddition label
added typefeature label
added UI text UX labels and removed typefeature label
1 Warning 67932c47: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
doc/user/project/working_with_projects.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Diana Zubova ( @dzubova
) (UTC+1, 1 hour behind@anna_vovchenko
)Natalia Tepluhina ( @ntepluhina
) (UTC+1, 1 hour behind@anna_vovchenko
)product intelligence Luis Mejia ( @lmejia2
) (UTC-6, 8 hours behind@anna_vovchenko
)Maintainer review is optional for product intelligence To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Andrew Fontaine
@nagyv-gitlab, could you please take a look if the event structure and the select work for you?
@jmandell, could you please review from the UX perspective?
@marcia, could you please take a look at the small UI text change?
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 18c74afe and 6b42135d
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.67 MB 3.67 MB - -0.0 % mainChunk 2.29 MB 2.29 MB - -0.0 %
Note: We do not have exact data for 18c74afe. So we have used data from: 7862c22b.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report for 6b42135d!review-qa-reliable:
test report
review-qa-smoke: test report- Resolved by Anna Vovchenko
- Resolved by Anna Vovchenko
- Resolved by Anna Vovchenko
- Resolved by Anna Vovchenko
- Resolved by Anna Vovchenko
- Resolved by Anna Vovchenko
- Resolved by Anna Vovchenko
- Resolved by Anna Vovchenko
- Resolved by Anna Vovchenko
added Technical Writing tw-weight3 twdoing labels
removed review request for @marcia
added workflowready for review label and removed workflowin dev label
- Resolved by Anna Vovchenko
@cngo, could you please do the frontend review?
@agarciatesares, could you please take a look from the product intelligence perspective?
requested review from @cngo and @agarciatesares
@jmandell
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
removed review request for @cngo
added product intelligenceapproved label
removed review request for @agarciatesares
requested review from @fneill
- A deleted user
added documentation label
- Resolved by Anna Vovchenko
- Resolved by Andrew Fontaine
@afontaine, could you please review as a maintainer?
requested review from @afontaine
added workflowin review label and removed workflowready for review label