Assign approvers based on code owners
-
Review changes -
-
Download -
Patches
-
Plain diff
The CE port is at https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22513
What does this MR do?
Assign approvers based on code owners
-
Only allow assigning when code owner feature is available -
Update owner when commit is pushed -
Give code owner as option when creating merge request -
Remove code owner as approver suggestion
Context
The major changes are:
-
overall_approvers
method now returnsUser
instead ofApprover
. This is because it needs to include code owners, which are dynamically calculated therefore does not have a correspondingApprover
column. - Due to the above, calls to
overall_approvers
are changed to work withUser
instead. - And due to the above, one action is added to enable deleting of approver by using
user_id
instead. This is because we only haveUser
instead ofApprover
, and if we want to get an user's approver it would cause extra database queries. At the end I decided to allow deleting of approvers by usinguser_id
instead. - For code push, we need to compute the difference in code owners, before and after the push.
What are the relevant issue numbers?
Closes #1012 (closed)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
Tests added for this feature/bug -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
EE specific content should be in the top level /ee
folder -
For a paid feature, have we considered GitLab.com plans, how it works for groups, and is there a design for promoting it to users who aren't on the correct plan?
Edited by 🤖 GitLab Bot 🤖
Merge request reports
Compare and
Show latest version
- version 3609bfbe01
- version 358f2bb246
- version 34f6615920
- version 33fa13bdad
- version 3258ed1abe
- version 3193a23dd3
- version 30412e9ed1
- version 29ac95c9b2
- version 28312cb746
- version 276ae2b9ba
- version 26abb17d66
- version 25d23c1cde
- version 243b8f926d
- version 235b4ceb8e
- version 22a414a44d
- version 2192d419a0
- version 2062a11860
- version 19cb65319b
- version 18f4d4194b
- version 17e778e90e
- version 161e4b9a10
- version 159d2c437f
- version 14e7f90d56
- version 13f328b840
- version 124113bb17
- version 11ecb71717
- version 10d0be1ba2
- version 9d4d1edc2
- version 886b8dcc0
- version 78b3a430e
- version 6d7cd1a4c
- version 561ab97c8
- version 4c58ee37d
- version 394fd727f
- version 21a814d64
- version 18ece126b
- master (base)
- latest versiona3572b8f7 commits,
- version 3609bfbe018 commits,
- version 358f2bb2467 commits,
- version 34f66159206 commits,
- version 33fa13bdad6 commits,
- version 3258ed1abe6 commits,
- version 3193a23dd36 commits,
- version 30412e9ed19 commits,
- version 29ac95c9b29 commits,
- version 28312cb7468 commits,
- version 276ae2b9ba9 commits,
- version 26abb17d669 commits,
- version 25d23c1cde6 commits,
- version 243b8f926d12 commits,
- version 235b4ceb8e12 commits,
- version 22a414a44d12 commits,
- version 2192d419a010 commits,
- version 2062a118609 commits,
- version 19cb65319b8 commits,
- version 18f4d4194b10 commits,
- version 17e778e90e8 commits,
- version 161e4b9a108 commits,
- version 159d2c437f8 commits,
- version 14e7f90d567 commits,
- version 13f328b84013 commits,
- version 124113bb179 commits,
- version 11ecb717178 commits,
- version 10d0be1ba26 commits,
- version 9d4d1edc25 commits,
- version 886b8dcc02 commits,
- version 78b3a430e17 commits,
- version 6d7cd1a4c17 commits,
- version 561ab97c814 commits,
- version 4c58ee37d13 commits,
- version 394fd727f13 commits,
- version 21a814d648 commits,
- version 18ece126b4 commits,
Compare changes
- Side-by-side
- Inline
There are no changes yet
No changes between version 4 and version 4
Loading