Replace deprecated usage of find/findAll in ee/spec/frontend/vue_mr_widget
What does this MR do and why?
Related to #350705 (closed)
Contents of this MR is autogenerated by snippet $2238476
Basically each time when @vue/test-utils
generates warning about find
/ findAll
being used to search for a component - we capture where it happens and do find & replace.
Please note, this series of MR does not intend to enable deprecation warnings (this will be done in separate MR) or to replace 100% occurences. Our intention is to do as much work automatically as possible, while splitting it in separate MRs to avoid conflicts
How to set up and validate locally
As soon as pipeline is green - we should be good! We're not touching any content except tests
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %14.8
added frontend test typemaintenance labels
assigned to @xanf
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Thomas Randolph ( @thomasrandolph
) (UTC-7, 9 hours behind@xanf
)Natalia Tepluhina ( @ntepluhina
) (UTC+1, 1 hour behind@xanf
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 1 commit
- cd6907b0 - Replace usage of find/findAll in ee/spec/frontend/vue_mr_widget
- Resolved by Enrique Alcántara
@thomasrandolph could you please review this and pass it to maintainer selected by roulette?
requested review from @thomasrandolph
requested review from @ealcantara and removed review request for @thomasrandolph
@thomasrandolph
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
enabled an automatic merge when the pipeline for 400b0169 succeeds
mentioned in commit f12a42b2
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label