Skip to content
Snippets Groups Projects

Add security training promo to security dashboard

All threads resolved!

What does this MR do and why?

It adds a promotion banner for the upcoming security training feature to the security dashboard:

Note: This is currently behind the secure_vulnerability_training feature flag and additional view-logic, like dismissal, etc. are tracked in separate issues and will be added in later MRs

Screenshots or screen recordings

promo_security_dashboard

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

  1. Enable the feature flag
echo "Feature.enable(:secure_vulnerability_training)" | rails c
  1. Navigate to a project's security dashboard ("Security & Compliance" -> "Security Dashboard")

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #350440 (closed)

Edited by David Pisek

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • David Pisek
  • David Pisek
  • added workflowin review label and removed workflowin dev label

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits ed96cd1c and 2260e639

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 3.66 MB 3.66 MB - -0.0 %
    mainChunk 2.28 MB 2.28 MB - 0.0 %

    :fearful: Significant Growth: 1

    Expand
    Entrypoint / Name Size before Size after Diff Diff in percent
    pages.groups.sso 70.7 KB 74.35 KB +3.65 KB 5.2 %

    :tada: Significant Reduction: 3

    Expand
    Entrypoint / Name Size before Size after Diff Diff in percent
    pages.registrations.groups_projects.new 29.33 KB 17.51 KB -11.83 KB -40.3 %
    pages.admin.integrations.edit 133.49 KB 130.28 KB -3.2 KB -2.4 %
    pages.groups.new 67.81 KB 65.93 KB -1.88 KB -2.8 %

    Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.

    Please consider pinging someone from the FE Foundations (@dmishunov, @justin_ho, @mikegreiling or @nmezzopera) for review, if you are unsure about the size increase.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Eugie Limpin approved this merge request

    approved this merge request

  • :wave: @eugielimpin, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • Eugie Limpin removed review request for @eugielimpin

    removed review request for @eugielimpin

  • Samantha Ming requested review from @eugielimpin and removed review request for @sming-gitlab

    requested review from @eugielimpin and removed review request for @sming-gitlab

  • Samantha Ming approved this merge request

    approved this merge request

  • Eugie Limpin unapproved this merge request

    unapproved this merge request

  • David Pisek added 154 commits

    added 154 commits

    Compare with previous version

  • David Pisek added 1 commit

    added 1 commit

    • 2260e639 - Reviewer feedback: specs improvements

    Compare with previous version

  • Author Maintainer

    Thanks for the great review and suggestions @sming-gitlab !

    @afontaine - Do you have capacity for the frontend maintainer review? :bow:

  • David Pisek requested review from @afontaine

    requested review from @afontaine

  • Eugie Limpin requested review from @mwoolf and removed review request for @eugielimpin

    requested review from @mwoolf and removed review request for @eugielimpin

  • Max Woolf approved this merge request

    approved this merge request

  • Max Woolf removed review request for @mwoolf

    removed review request for @mwoolf

  • Andrew Fontaine
  • Andrew Fontaine resolved all threads

    resolved all threads

  • Andrew Fontaine approved this merge request

    approved this merge request

  • thanks @dpisek! setting this to MWPS

  • Andrew Fontaine enabled an automatic merge when the pipeline for cee7f2d1 succeeds

    enabled an automatic merge when the pipeline for cee7f2d1 succeeds

  • Andrew Fontaine mentioned in commit 483817ce

    mentioned in commit 483817ce

  • David Pisek resolved all threads

    resolved all threads

  • David Pisek mentioned in issue #350684

    mentioned in issue #350684

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • David Pisek mentioned in merge request !81934 (merged)

    mentioned in merge request !81934 (merged)

  • Please register or sign in to reply
    Loading