Remove ci_archived_build_trace_checksum feature flag
What does this MR do and why?
Related to #340737 (closed), #259619 (closed)
This feature was enabled on GitLab.com a long time ago and I think it's safe to remove the feature flag because the checksum values match:
https://console.postgres.ai/gitlab/gitlab-production-tunnel-pg12/sessions/8062/commands/28746
select * from ci_build_trace_metadata where checksum is not null and remote_checksum <> '' and checksum <> remote_checksum;
(actual time=332273.441..332273.466 rows=0 loops=1)
I'm doing remote_checksum <> ''
because there was a bug in the first implementation that was returning empty checksums.
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %14.7
added auto updated feature flag missed:14.5 missed:14.6 labels
assigned to @mbobin
removed missed:14.5 label
removed missed:14.6 label
removed auto updated label
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- A deleted user
added backend label
1 Warning Please add a merge request type to this merge request. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Tiger Watson ( @tigerwnz
) (UTC+11, 9 hours ahead of@mbobin
)Sincheol (David) Kim ( @dskim_gitlab
) (UTC+10.5, 8.5 hours ahead of@mbobin
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Sincheol (David) Kim
@tigerwnz could you have a look at this?
requested review from @tigerwnz
mentioned in issue #340737 (closed)
requested review from @dskim_gitlab and removed review request for @tigerwnz
@tigerwnz
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
enabled an automatic merge when the pipeline for a92a6230 succeeds
mentioned in commit 37c553d0
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!562 (merged)