Skip to content
Snippets Groups Projects

Remove ci_archived_build_trace_checksum feature flag

Merged Marius Bobin requested to merge 340737-remove-ci_archived_build_trace_checksum-ff into master
All threads resolved!

What does this MR do and why?

Related to #340737 (closed), #259619 (closed)

This feature was enabled on GitLab.com a long time ago and I think it's safe to remove the feature flag because the checksum values match:

https://console.postgres.ai/gitlab/gitlab-production-tunnel-pg12/sessions/8062/commands/28746

select * from ci_build_trace_metadata where checksum is not null and remote_checksum <> '' and checksum <> remote_checksum;
(actual time=332273.441..332273.466 rows=0 loops=1)

I'm doing remote_checksum <> '' because there was a bug in the first implementation that was returning empty checksums.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Marius Bobin

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading