Remove event hub from integrations app

What does this MR do and why?

Related to #348382 (closed).

This MR removes the event hub from the Integrations Vue app .

The final event to remove was VALIDATE_INTEGRATION_FORM_EVENT. To remove it, we've added isValidated props to the form field components, and set this prop from the parent component, integration_form.vue. When we need form validation, integration_form.vue sets these props to true, and the form field components handle as necessary, internally.

There are no user-facing changes in this MR

Screenshots or screen recordings

Screenshots demonstrate that form validation works as expected (unchanged):

event_hub

How to set up and validate locally

You'll need to set up an integration, and fill out the form fields incorrectly to trigger form validation.

To set up an integration:

1. Navigate to a GitLab project.
2. Select Settings > Integrations from the left sidebar.
3. Select Jira.
4. Complete the form details, but leave Web URL blank.
5. Click "save changes".
6. Observe. A form validation message should appear on the Web URL field.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

Related to #348382 (closed)

changed milestone to %14.7

added Deliverable [deprecated] Accepting merge requests frontend groupintegrations [DEPRECATED] maintenancerefactor sectiondev typemaintenance workflowin dev + 1 deleted label

assigned to @tomquirk

removed [deprecated] Accepting merge requests label

	1 Message
	CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog. If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message. If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
frontend	Scott Stern (@sstern) (UTC-8, 17.5 hours behind @tomquirk)	Jose Ivan Vargas (@jivanvl) (UTC-6, 15.5 hours behind @tomquirk)
~"group::integrations" (frontend)	Justin Ho (@justin_ho) (UTC+7, 2.5 hours behind @tomquirk)	Maintainer review is optional for ~"group::integrations" (frontend)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

added 1 commit

• c606724d - Remove event hub from integrations app

Compare with previous version

Allure report

allure-report-publisher generated test report for 2a036b35!

review-qa-reliable: test report
review-qa-smoke: test report

added 1 commit

• c8ed22d4 - Remove event hub from integrations app

Compare with previous version

marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

changed the description

Hey again @justin_ho - one final MR that I'd love for you to review, if possible!

Again, this MR targets !77934 (merged) - I'll assign the maintainer when this MR is ready to merge

requested review from @justin_ho

added 808 commits

• c8ed22d4...4c31a8e8 - 807 commits from branch 347506-integration-form-haml-to-vue
• 70d8ba87 - Remove event hub from integrations app

Compare with previous version

added 2 commits

• 59353a45 - 1 commit from branch 347506-integration-form-haml-to-vue
• 23a89c71 - Remove event hub from integrations app

Compare with previous version

added 1 commit

• 94ea90a2 - Remove event hub from integrations app

Compare with previous version

removed review request for @justin_ho

changed target branch from 347506-integration-form-haml-to-vue to master

added 1 commit

• c6af1e79 - Remove event hub from integrations app

Compare with previous version

added 383 commits

• c6af1e79...8b5b39ce - 382 commits from branch master
• 3165d2fc - Remove event hub from integrations app

Compare with previous version

marked this merge request as ready

Hey @jannik_lehmann, could you please review this MR?

changed milestone to %14.8

requested review from @jannik_lehmann

added workflowin review label and removed workflowin dev label

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 84d6ae0e and 2a036b35

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	3.66 MB	3.66 MB	-	-0.0 %
mainChunk	2.28 MB	2.28 MB	-	0.0 %

---

Note: We do not have exact data for 84d6ae0e. So we have used data from: 841425a6.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun the bundle-size-review job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

Please look at the full report for more details

---

Read more about how this report works.

Generated by Danger

added 1 commit

• 89d3db8c - Remove event hub from integrations app

Compare with previous version

approved this merge request

@tomquirk thanks for providing a video demo, I was able to reproduce this. Looking through the changes nothing but praise to be found from my side. Excellent job!

@jivanvl can you take over for maintainer review? Thank you!

requested review from @jivanvl and removed review request for @jannik_lehmann

@jannik_lehmann, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

For more info, please refer to the following links:

• rspec minimal jobs
• jest minimal jobs
• merging a merge request.

resolved all threads

approved this merge request

Looks good to me! I love these kind of MR's

resolved all threads

enabled an automatic merge when the pipeline for c3997710 succeeds

@tomquirk Merge conflicts, can you please take a look? Assign me back once this is ready to go

removed review request for @jivanvl

aborted the automatic merge because source branch was updated

added 365 commits

• 89d3db8c...bbf52b48 - 364 commits from branch master
• 2a036b35 - Remove event hub from integrations app

Compare with previous version

requested review from @jivanvl

resolved all threads

enabled an automatic merge when the pipeline for db4af60d succeeds

merged

mentioned in commit 56300cc5

added workflowstaging-canary label and removed workflowin review label

added workflowstaging label and removed workflowstaging-canary label

added workflowcanary label and removed workflowstaging label

added workflowproduction label and removed workflowcanary label

added releasedcandidate label

added releasedpublished label and removed releasedcandidate label

added devopsfoundations label and removed 1 deleted label

added groupimport and integrate label and removed groupintegrations [DEPRECATED] label