Remove unnecessary classes from VSA Path navigation
What does this MR do and why?
This MR removes the classes added to the VSA path navigation. They are not needed, as they result in a shift of the page content once the loading in finished.
Screenshots or screen recordings
Before | After |
---|---|
Screen_Recording_2022-01-12_at_12.56.22 | Screen_Recording_2022-01-12_at_12.55.46 |
How to set up and validate locally
- Browse to VSA and watch the page load
- http://localhost:3000/groups/gitlab-org/-/analytics/value_stream_analytics
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #217485 (closed)
Merge request reports
Activity
changed milestone to %14.7
assigned to @blabuschagne
removed workflowready for development label
added 351 commits
-
ed1096ed...4604394a - 350 commits from branch
master
- 2d81414c - Fix shift after VSA path load
-
ed1096ed...4604394a - 350 commits from branch
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the ~"type::tooling", ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Justin Ho ( @justin_ho
) (UTC+7, 6 hours ahead of@blabuschagne
)Nicolò Maria Mezzopera ( @nmezzopera
) (UTC+1, same timezone as@blabuschagne
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermarked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
added typemaintenance label
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 24c48530 and 51961b48
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.66 MB 3.66 MB - 0.0 % mainChunk 2.28 MB 2.28 MB - 0.0 %
Note: We do not have exact data for 24c48530. So we have used data from: 54368e77.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report for 51961b48!review-qa-smoke:
test report
review-qa-reliable: test reportadded 80 commits
-
2d81414c...7e9246e4 - 79 commits from branch
master
- 009f024f - Fix shift after VSA path load
-
2d81414c...7e9246e4 - 79 commits from branch
added 126 commits
-
009f024f...b967b1c5 - 125 commits from branch
master
- 51961b48 - Fix shift after VSA path load
-
009f024f...b967b1c5 - 125 commits from branch
- Resolved by Nicolò Maria Mezzopera
@justin_ho could you please review this tiny change too? Review roulette seems to like you
requested review from @justin_ho
requested review from @nmezzopera and removed review request for @justin_ho
@justin_ho
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
requested review from @npost
mentioned in commit fef0481d
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in issue #217485 (closed)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!562 (merged)