Add `Delete` button to label edit view
What does this MR do and why?
Related to #345195 (closed)
Adds a Delete
button to the label edit view. This change affects Project, Group, and Admin label management.
Screenshots or screen recordings
Admin labels
Desktop
Before | After |
---|---|
![]() |
![]() |
Mobile
Before | After |
---|---|
![]() |
![]() |
Project labels
Desktop
Before | After |
---|---|
![]() |
![]() |
Mobile
Before | After |
---|---|
![]() |
![]() |
Group labels
Desktop
Before | After |
---|---|
![]() |
![]() |
Mobile
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Admin labels
- Navigate to
/admin/labels
- Create a label
- Edit the label
Project labels
- Navigate to a project ->
Project information
->Labels
- Create a label
- Edit the label
Group labels
- Navigate to a group ->
Group information
->Labels
- Create a label
- Edit the label
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %14.7
added devopsmanage documentation frontend release post itemin review sectiondev typefeature workflowin dev + 1 deleted label
assigned to @peterhegman
- A deleted user
added backend label
1 Warning This merge request contains deprecated components. Please consider using Pajamas components instead. 1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
doc/user/admin_area/img/admin_labels_v14_7.png
doc/user/admin_area/labels.md
doc/user/project/labels.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Deprecated components
These deprecated components are in the process of being migrated. Please consider using Pajamas components instead.
- %button.btn.btn-
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Tiger Watson ( @tigerwnz
) (UTC+11, 19 hours ahead of@peterhegman
)Bob Van Landuyt ( @reprazent
) (UTC+1, 9 hours ahead of@peterhegman
)frontend Sheldon Led ( @sheldonled
) (UTC+0, 8 hours ahead of@peterhegman
)Frédéric Caplette ( @f_caplette
) (UTC-5, 3 hours ahead of@peterhegman
)test Quality for spec/features/*
Andrejs Cunskis ( @acunskis
) (UTC+1, 9 hours ahead of@peterhegman
)Maintainer review is optional for test Quality for spec/features/*
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 708bf188 and 6fbe0442
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.66 MB 3.66 MB - 0.0 % mainChunk 2.28 MB 2.28 MB - 0.0 % Significant Growth: 3Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.admin.labels.edit 11.33 KB 143.74 KB +132.41 KB 1168.5 % pages.projects.labels.edit 823.78 KB 956.19 KB +132.41 KB 16.1 % pages.groups.labels.edit 24.19 KB 156.6 KB +132.41 KB 547.3 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@dmishunov
,@justin_ho
,@mikegreiling
or@nmezzopera
) for review, if you are unsure about the size increase.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report for 6fbe0442!review-qa-reliable:
test report
review-qa-smoke: test reportadded 152 commits
-
10f7f3bc...1a66a293 - 151 commits from branch
master
- e8016845 - Add `Delete` button to label edit view
-
10f7f3bc...1a66a293 - 151 commits from branch
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Thong Kuah
@seanarnold, @viktomas, @acunskis can you review this MR when you have time?
requested review from @seanarnold, @viktomas, and @acunskis
- Resolved by Thong Kuah
@npost can you please give this a UX review when you have time?
requested review from @npost
- Resolved by Peter Hegman
@fneill can you take a look at the doc changes when you have a chance?
requested review from @fneill
- Resolved by Peter Hegman
- Resolved by Sean Arnold
- Resolved by Peter Hegman
requested review from @ntepluhina and removed review request for @viktomas
@viktomas
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
removed review request for @ntepluhina
added Technical Writing label
- Resolved by Peter Hegman
- Resolved by Peter Hegman
- Resolved by Peter Hegman
added twfinished label
removed review request for @fneill
removed review request for @acunskis
added 410 commits
-
e8016845...b301b31e - 407 commits from branch
master
- 7663bbe8 - Add `Delete` button to label edit view
- 5c9a34cd - Move checking if `label#subject` exists to `LabelPresenter`
- 1540deba - Update docs per TW reviewer feedback
Toggle commit list-
e8016845...b301b31e - 407 commits from branch
- Resolved by Peter Hegman
- Resolved by Sean Arnold
- Resolved by Thong Kuah
Hi @peterhegman I've made a couple of minor suggestions. Let me know what you think
.
removed review request for @seanarnold
added 68 commits
-
1540deba...2a8c0142 - 64 commits from branch
master
- d1d9eebe - Add `Delete` button to label edit view
- a62b1c3f - Move checking if `label#subject` exists to `LabelPresenter`
- 3d887165 - Update docs per TW reviewer feedback
- b46ac9dd - Refactor `subject_name` and `subject_full_name` delegation
Toggle commit list-
1540deba...2a8c0142 - 64 commits from branch
added 1 commit
- dfa98eb8 - Refactor `subject_name` and `subject_full_name` delegation
requested review from @seanarnold
removed review request for @seanarnold
requested review from @tkuah
- Resolved by Peter Hegman
- Resolved by Jan Provaznik
Just one question above, thanks @peterhegman . Can you please resolve all threads above if possible ?
I am going on PTO after today, so please find another backend maintainer to merge. Thanks!
removed review request for @tkuah
added 318 commits
-
dfa98eb8...708bf188 - 313 commits from branch
master
- 838ce306 - Add `Delete` button to label edit view
- bdbc6a8a - Move checking if `label#subject` exists to `LabelPresenter`
- 94fc540f - Update docs per TW reviewer feedback
- 9de39452 - Refactor `subject_name` and `subject_full_name` delegation
- 6fbe0442 - Remove unneeded `Struct`
Toggle commit list-
dfa98eb8...708bf188 - 313 commits from branch
requested review from @jprovaznik
removed workflowin dev label
removed review request for @jprovaznik
requested review from @jprovaznik
- Resolved by Peter Hegman
Thanks @peterhegman, LGTM
, MWPS set
enabled an automatic merge when the pipeline for 6c1ae69d succeeds
mentioned in commit cafcde8c
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added docsfeature label
added workflowproduction label and removed workflowcanary label
mentioned in merge request gitlab-com/www-gitlab-com!96705 (merged)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!562 (merged)
added devopsdata stores grouptenant scale sectioncore platform labels and removed devopsmanage sectiondev + 1 deleted label