Skip to content
Snippets Groups Projects

Add `Delete` button to label edit view

Merged Peter Hegman requested to merge 345195-add-a-delete-button-to-the-edit-label-pages into master
All threads resolved!

What does this MR do and why?

Related to #345195 (closed)

Adds a Delete button to the label edit view. This change affects Project, Group, and Admin label management.

Screenshots or screen recordings

Admin labels

Desktop

Before After
Screen_Shot_2022-01-11_at_8.48.30_AM Screen_Shot_2022-01-11_at_8.38.33_AM

Mobile

Before After
Screen_Shot_2022-01-11_at_8.49.06_AM Screen_Shot_2022-01-11_at_8.39.37_AM

Project labels

Desktop

Before After
Screen_Shot_2022-01-11_at_8.49.54_AM Screen_Shot_2022-01-11_at_8.40.53_AM

Mobile

Before After
Screen_Shot_2022-01-11_at_8.50.39_AM Screen_Shot_2022-01-11_at_8.41.24_AM

Group labels

Desktop

Before After
Screen_Shot_2022-01-11_at_8.51.28_AM Screen_Shot_2022-01-11_at_8.42.23_AM

Mobile

Before After
Screen_Shot_2022-01-11_at_8.52.08_AM Screen_Shot_2022-01-11_at_8.43.03_AM

How to set up and validate locally

Admin labels

  1. Navigate to /admin/labels
  2. Create a label
  3. Edit the label

Project labels

  1. Navigate to a project -> Project information -> Labels
  2. Create a label
  3. Edit the label

Group labels

  1. Navigate to a group -> Group information -> Labels
  2. Create a label
  3. Edit the label

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Peter Hegman

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tomas Vik
  • Tomas Vik
  • Tomas Vik approved this merge request

    approved this merge request

  • Tomas Vik requested review from @ntepluhina and removed review request for @viktomas

    requested review from @ntepluhina and removed review request for @viktomas

  • :wave: @viktomas, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • Natalia Tepluhina approved this merge request

    approved this merge request

  • Natalia Tepluhina removed review request for @ntepluhina

    removed review request for @ntepluhina

  • Nick Post approved this merge request

    approved this merge request

  • Fiona Neill
  • Fiona Neill
  • Fiona Neill
  • added twfinished label

  • Fiona Neill approved this merge request

    approved this merge request

  • Fiona Neill removed review request for @fneill

    removed review request for @fneill

  • Andrejs Cunskis approved this merge request

    approved this merge request

  • Andrejs Cunskis removed review request for @acunskis

    removed review request for @acunskis

  • Peter Hegman added 410 commits

    added 410 commits

    • e8016845...b301b31e - 407 commits from branch master
    • 7663bbe8 - Add `Delete` button to label edit view
    • 5c9a34cd - Move checking if `label#subject` exists to `LabelPresenter`
    • 1540deba - Update docs per TW reviewer feedback

    Compare with previous version

  • Sean Arnold
  • Sean Arnold removed review request for @seanarnold

    removed review request for @seanarnold

  • Peter Hegman added 68 commits

    added 68 commits

    • 1540deba...2a8c0142 - 64 commits from branch master
    • d1d9eebe - Add `Delete` button to label edit view
    • a62b1c3f - Move checking if `label#subject` exists to `LabelPresenter`
    • 3d887165 - Update docs per TW reviewer feedback
    • b46ac9dd - Refactor `subject_name` and `subject_full_name` delegation

    Compare with previous version

  • Peter Hegman added 1 commit

    added 1 commit

    • dfa98eb8 - Refactor `subject_name` and `subject_full_name` delegation

    Compare with previous version

  • Peter Hegman requested review from @seanarnold

    requested review from @seanarnold

  • Sean Arnold approved this merge request

    approved this merge request

  • Sean Arnold removed review request for @seanarnold

    removed review request for @seanarnold

  • Peter Hegman requested review from @tkuah

    requested review from @tkuah

  • Thong Kuah
  • Thong Kuah removed review request for @tkuah

    removed review request for @tkuah

  • Peter Hegman added 318 commits

    added 318 commits

    • dfa98eb8...708bf188 - 313 commits from branch master
    • 838ce306 - Add `Delete` button to label edit view
    • bdbc6a8a - Move checking if `label#subject` exists to `LabelPresenter`
    • 94fc540f - Update docs per TW reviewer feedback
    • 9de39452 - Refactor `subject_name` and `subject_full_name` delegation
    • 6fbe0442 - Remove unneeded `Struct`

    Compare with previous version

  • Peter Hegman resolved all threads

    resolved all threads

  • Peter Hegman requested review from @jprovaznik

    requested review from @jprovaznik

  • Jan Provaznik approved this merge request

    approved this merge request

  • Jan Provaznik removed review request for @jprovaznik

    removed review request for @jprovaznik

  • Peter Hegman requested review from @jprovaznik

    requested review from @jprovaznik

  • Jan Provaznik resolved all threads

    resolved all threads

  • Jan Provaznik enabled an automatic merge when the pipeline for 6c1ae69d succeeds

    enabled an automatic merge when the pipeline for 6c1ae69d succeeds

  • Peter Hegman resolved all threads

    resolved all threads

  • merged

  • Jan Provaznik mentioned in commit cafcde8c

    mentioned in commit cafcde8c

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • Please register or sign in to reply
    Loading