Update gitlab-omniauth-openid-connect gem to support ECSDA keys
What does this MR do and why?
Diff: https://my.diffend.io/gems/gitlab-omniauth-openid-connect/0.8.0/0.9.1
This commit also updates some other dependencies that appears to fix verification of LetsEncrypt (https://github.com/nahi/httpclient/issues/445) certs by making the underlying HTTP client use the OS certificates:
- openid_connect: https://my.diffend.io/gems/openid_connect/1.2.0/1.3.0
- swd: https://my.diffend.io/gems/swd/1.1.0/1.2.0
- webfinger: https://my.diffend.io/gems/webfinger/1.1.0/1.2.0
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @stanhu
added 1 commit
- 22ade28a - Update gitlab-omniauth-openid-connect gem to support ECSDA keys
- A deleted user
added backend label
1 Warning Please add a merge request type to this merge request. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Marc Shaw ( @marc_shaw
) (UTC+1, 9 hours ahead of@stanhu
)Sincheol (David) Kim ( @dskim_gitlab
) (UTC+10.5, 18.5 hours ahead of@stanhu
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 1 commit
- 726c5a27 - Update gitlab-omniauth-openid-connect gem to support ECSDA keys
changed milestone to %14.7
added maintenancedependency label
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
requested review from @dblessing
added 1 commit
- 1c8377c8 - Update gitlab-omniauth-openid-connect gem to support ECSDA keys
requested review from @igor.drozdov and removed review request for @dblessing
@dblessing
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
@stanhu @dblessing thanks, LGTM
enabled an automatic merge when the pipeline for 03fb61ac succeeds
mentioned in commit ef45a827
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!562 (merged)