Add a retry around pipeline click_job
What does this MR do and why?
Describe in detail what your merge request does and why.
Multiple failures across master and staging were observed around different tests all with the same failure
Failure/Error: pipeline.click_job('deploy')
QA::Page::Validatable::PageValidationError:
pipeline_path did not appear on QA::Page::Project::Job::Show as expected
From screenshot it looks like the test is still on the pipeline page and therefore validation of job page elements will fail.
This MR is an attempt to add a retry here. The failure was not replicated locally.
Related issues hoping to address
browser_ui/5_package/package_registry/helm_registry_spec.rb
#347006 (closed)
browser_ui/6_release/pages/pages_pipeline_spec.rb
#346983 (closed)
browser_ui/5_package/package_registry/maven_repository_spec.rb
#346977 (closed)
browser_ui/5_package/dependency_proxy/dependency_proxy_spec.rb
#346966 (closed)
browser_ui/5_package/container_registry/container_registry_omnibus_spec.rb
#346957 (closed)
browser_ui/5_package/package_registry/nuget_repository_spec.rb
#346946 (closed)
browser_ui/4_verify/pipeline/locked_artifacts_spec.rb
#346915 (closed)
browser_ui/5_package/container_registry/container_registry_omnibus_spec.rb
#346903 (closed)
browser_ui/5_package/package_registry/npm/npm_instance_level_spec.rb
#346838 (closed)
browser_ui/4_verify/ci_variable/pipeline_with_protected_variable_spec.rb
#346820 (closed)
browser_ui/5_package/package_registry/maven_gradle_repository_spec.rb
#346813 (closed)
Go through the pipeline for this MR and check:
- For affected tests listed above do they
- Pass - All pass
✅ - Log show a retry on
click_job
- See 28925be6 (comment 752008670) for an example of where logs show the retry✅
- Pass - All pass
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Run one of the failing tests against a GDK instance eg.
CHROME_HEADLESS=false bundle exec bin/qa Test::Instance::All http://GDK/ ./qa/specs/features/browser_ui/4_verify/pipeline/locked_artifacts_spec.rb
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.