In-app awareness of Registration Features - Group access by IP address

What does this MR do and why?

Related to #341949 (closed)

To increase discoverability for the features that can be enabled with Registration features, we'll be presenting in-app messages/hints. In this case, for setting allowed IP addresses.

Criteria to show the CTA

The offer shouldn't be presented to licensed instances because they already have the paid features available, so the callout (to enable features they already have) doesn't make sense. The decision on whether to show the offer is on the true/false of whether Service Ping is enabled, not on whether Registration Features is enabled.

Instance Type	License Type	Service Ping Setting	Expected Behavior
CE	Unlicensed	Off	Link to docs
EE	Unlicensed	Off	Link to admin setting
EE	Licensed	Off	Do not present offer
CE	Unlicensed	On	Do not present offer
EE	Unlicensed	On	Do not present offer
EE	Licensed	On	Do not present offer

Screenshots or screen recordings

Enabled feature for reference

---

When Service Ping is disabled

The CTA is always hidden if Service Ping is enabled.

Before (hidden)	After (CE)	After (EE)

How to set up and validate locally

1. Optionally restart gdk as FOSS (FOSS_ONLY=1 gdk restart) to test like a CE instance.
2. Go to any group’s Settings > General page. and expand the Permissions, LFS, 2FA section.
3. Scroll to the Allow access to the following IP addresses section.
4. Toggle a local license/subscription and/or service ping/registration features.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

ee/spec/views/groups/edit.html.haml_spec.rb

@@ -19,7 +19,6 @@
       it 'renders ranges in comma separated format' do
         render
 
-        expect(rendered).to render_template('groups/settings/_ip_restriction_form_group')
         expect(rendered).to render_template('groups/settings/_ip_restriction')
         expect(rendered).to(have_field('group_ip_restriction_ranges',
                                        disabled: false,
@@ -32,8 +31,7 @@
       it 'does not render the ranges' do
         render
 
-        expect(rendered).to render_template('groups/settings/_ip_restriction_form_group')
-        expect(rendered).not_to render_template('groups/settings/_ip_restriction')
+        expect(rendered).to render_template('groups/settings/_ip_restriction')
         expect(rendered).not_to have_field('group_ip_restriction_ranges', type: :hidden)
       end
     end
@@ -42,8 +40,19 @@
       it 'renders a placeholder input with registration features message' do
         render
 
-        expect(rendered).to render_template('shared/_registration_features_discovery_message')
         expect(rendered).to have_field('disabled_ip_restriction_ranges', disabled: true)
+        expect(rendered).to have_content(s_("RegistrationFeatures|Want to %{feature_title} for free?") % { feature_title: s_('RegistrationFeatures|use this feature') })
+        expect(rendered).to have_link(s_('RegistrationFeatures|Registration Features Program'))
+        expect(rendered).to have_link(s_('RegistrationFeatures|Enable Service Ping and register for this feature.'))
+      end
+    end
+
+    shared_examples_for 'does not render registration features prompt' do
+      it 'does not render a placeholder input with registration features message' do
+        render
+
+        expect(rendered).not_to have_field('disabled_ip_restriction_ranges', disabled: true)
+        expect(rendered).not_to have_content(s_("RegistrationFeatures|Want to %{feature_title} for free?") % { feature_title: s_('RegistrationFeatures|use this feature') })
       end
     end
 
@@ -63,12 +72,14 @@
           let(:ranges) { ['192.168.0.0/24'] }
 
           it_behaves_like 'renders ip_restriction setting'
+          it_behaves_like 'does not render registration features prompt'
         end
 
         context 'with multiple subnets' do
           let(:ranges) { ['192.168.0.0/24', '192.168.1.0/8'] }
 
           it_behaves_like 'renders ip_restriction setting'
+          it_behaves_like 'does not render registration features prompt'
         end
       end
     end
@@ -85,7 +96,39 @@
       end
 
       it_behaves_like 'does not render ip_restriction setting'
-      it_behaves_like 'renders registration features prompt'
+    end
+
+    context 'prompt user about registration features' do
+      context 'with service ping disabled' do
+        before do
+          stub_application_setting(usage_ping_enabled: false)
+        end
+
+        context 'with no license' do
+          before do
+            allow(License).to receive(:current).and_return(nil)
+          end
+
+          it_behaves_like 'renders registration features prompt'
+        end
+
+        context 'with a valid license' do
+          before do
+            license = build(:license)
+            allow(License).to receive(:current).and_return(license)
+          end
+
+          it_behaves_like 'does not render registration features prompt'
+        end
+      end
+
+      context 'with service ping enabled' do
+        before do
+          stub_application_setting(usage_ping_enabled: true)
+        end
+
+        it_behaves_like 'does not render registration features prompt'
+      end
     end
   end