Resolve escalation status when incident is closed
What does this MR do and why?
Implements #334713 (closed)
Sets an incident's escalation status to "Resolved" on close, and adds a system note.
Screenshots or screen recordings
How to set up and validate locally
- Navigate to Monitor > Incidents
- Click "Create incident" button to navigate to "New issue" page.
- Provide an incident title
- Ensure type "Incident" is selected
- Click "Create issue" button
- Click "Close incident" from the incident's page
- That should close an incident and add a system note
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %14.5
assigned to @ck3g
- A deleted user
added backend label
1 Warning Please add a merge request type to this merge request. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Sashi Kumar Kumaresan ( @sashi_kumar
) (UTC+5.5, 4.5 hours ahead of@ck3g
)Matthias Käppler ( @mkaeppler
) (UTC+1, same timezone as@ck3g
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 325 commits
-
28159c07...8e1fbdf4 - 323 commits from branch
master
- 8b69a5a4 - Resolve escalation status when incident is closed
- 23e2cf01 - Add a system note on resolve an incident
-
28159c07...8e1fbdf4 - 323 commits from branch
- Resolved by Gabriel Mazetto
Hey @syasonik could you please give it a look?
requested review from @syasonik
- Resolved by Sarah Yasonik
- Resolved by Sarah Yasonik
- Resolved by Sarah Yasonik
- Resolved by Sarah Yasonik
- Resolved by Sarah Yasonik
removed review request for @syasonik
Allure report
allure-report-publisher
generated test report for 23e2cf01!package-and-qa:
test reportadded 926 commits
-
23e2cf01...edf6df27 - 924 commits from branch
master
- cc875bcf - Resolve escalation status when incident is closed
- bcf9daa8 - Add a system note on resolve an incident
-
23e2cf01...edf6df27 - 924 commits from branch
requested review from @syasonik
@syasonik
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
@ck3g LGTM! I've set it to MWPS
enabled an automatic merge when the pipeline for 0b2a81ed succeeds
mentioned in commit 10438b18
added workflowstaging-canary label and removed workflowready for development label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in merge request !66165 (merged)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label