Skip to content
Snippets Groups Projects

Allow maintainers to set MR approval settings

Merged Max Woolf requested to merge mw/mr-approval-settings-permissions-bug into master
All threads resolved!

What does this MR do and why?

Describe in detail what your merge request does and why.

During the rollout of group-level MR approval settings, it became clear that we had accidentally removed access for project maintainers to set MR approval settings.

This MR reinstates that access.

There are no documentation changes to make because the docs are already correct and this changes the functionality to correctly match itl.

Screenshots or screen recordings (When group_merge_request_approval_settings_feature_flag is enabled)

Before

Screenshot_2021-10-18_at_10.17.00

After

Screenshot_2021-10-18_at_10.18.36

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Huzaifa Iftikhar approved this merge request

    approved this merge request

  • Huzaifa Iftikhar requested review from @reprazent and removed review request for @huzaifaiftikhar1

    requested review from @reprazent and removed review request for @huzaifaiftikhar1

  • :wave: @huzaifaiftikhar1, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • Huzaifa Iftikhar resolved all threads

    resolved all threads

  • Author Maintainer

    Pipeline is failing because master is currently broken.

  • Bob Van Landuyt approved this merge request

    approved this merge request

  • Bob Van Landuyt resolved all threads

    resolved all threads

  • Thank you @mwoolf and @huzaifaiftikhar1! Nothing to add. Let's see if master has been fixed already :smile:.

  • Bob Van Landuyt enabled an automatic merge when the pipeline for 6a1d14e8 succeeds

    enabled an automatic merge when the pipeline for 6a1d14e8 succeeds

  • mentioned in issue #285410 (closed)

  • Bob Van Landuyt mentioned in commit 9573d754

    mentioned in commit 9573d754

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • Please register or sign in to reply
    Loading