Allow maintainers to set MR approval settings
What does this MR do and why?
Describe in detail what your merge request does and why.
During the rollout of group-level MR approval settings, it became clear that we had accidentally removed access for project maintainers to set MR approval settings.
This MR reinstates that access.
There are no documentation changes to make because the docs are already correct and this changes the functionality to correctly match itl.
group_merge_request_approval_settings_feature_flag
is enabled)
Screenshots or screen recordings (When Before
After
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
changed milestone to %14.5
assigned to @mwoolf
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Sashi Kumar Kumaresan ( @sashi_kumar
) (UTC+5.5, 4.5 hours ahead of@mwoolf
)James Fargher ( @proglottis
) (UTC+13, 12 hours ahead of@mwoolf
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger@huzaifaiftikhar1 Feel ready to take on this initial backend code review?
requested review from @huzaifaiftikhar1
- Resolved by Huzaifa Iftikhar
- Resolved by Bob Van Landuyt
@reprazent Can you do a maintainer backend review on this one?
requested review from @reprazent and removed review request for @huzaifaiftikhar1
@huzaifaiftikhar1
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
Thank you @mwoolf and @huzaifaiftikhar1! Nothing to add. Let's see if master has been fixed already
.enabled an automatic merge when the pipeline for 6a1d14e8 succeeds
mentioned in issue #285410 (closed)
mentioned in commit 9573d754
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!306 (merged)
added releasedpublished label and removed releasedcandidate label